Skip to content

fix(web): wrap long bot names in delete and clear dialogs - #765

Merged
elie222 merged 3 commits into
elie222:mainfrom
RA-h:fix/delete-dialog-long-name
Sep 7, 2026
Merged

elie222 merged 3 commits into
elie222:mainfrom
RA-h:fix/delete-dialog-long-name

Conversation

@RA-h

@RA-h RA-h commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Why

A bot with a very long unbroken name overflows the Delete confirmation dialog — the title runs past the dialog's right edge instead of wrapping.

What

  • Added break-words to the DeleteBotDialog title so long unbroken names wrap inside the dialog.
  • Same one-line fix on the Clear-conversation dialog title, which interpolates bot.name the same way and had the identical overflow.

How tested

  • Biome check on dialogs.tsx: clean.
  • tsc --noEmit (web): clean.
  • Web unit tests: 38 files / 207 tests pass.
  • bot-crud.spec.ts exercises the delete flow in CI — will link the CI E2E screenshot gallery here once CI runs.

Summary by CodeRabbit

  • Bug Fixes
    • Long bot names now wrap correctly in conversation-clearing and bot-deletion dialog titles instead of overflowing.
    • Dialogs with lengthy content now stay within the screen and support vertical scrolling for easier access to all actions.

@vercel

vercel Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
rakazo-www Skipped Skipped Sep 7, 2026 6:34am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0051f6ce-27e5-41a9-b75c-6aa4062ba14b

📥 Commits

Reviewing files that changed from the base of the PR and between 8bd8496 and a791853.

📒 Files selected for processing (2)
  • apps/web/e2e/bot-crud.spec.ts
  • packages/ui-web/src/components/ui/alert-dialog.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Dialog titles now wrap long bot names, and dialog content can scroll within a height limit. End-to-end tests cover long-name deletion and capture the clear-conversation confirmation dialog.

Changes

Long bot name dialog coverage

Layer / File(s) Summary
Apply wrapping and scrolling to dialogs
apps/web/src/pages/shell/dialogs.tsx, packages/ui-web/src/components/ui/alert-dialog.tsx
The clear-conversation and delete alert titles use break-words. Alert dialog content has a maximum height and vertical scrolling.
Validate dialog behavior
apps/web/e2e/bot-crud.spec.ts, apps/web/e2e/bot-organization.spec.ts
The CRUD test uses a 48-character unbroken bot name and verifies deletion, removal, and redirect behavior. The organization test captures the clear-conversation confirmation dialog.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a7918

Long unbroken bot names now remain within delete and clear-conversation dialogs, with oversized dialog content scrollable. The updated deletion flow coverage supports the intended behavior, with no remaining merge-readiness risk identified.

Suggested reviewers: elie222

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: wrapping long bot names in the delete and clear dialogs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes long bot names wrap in clear and delete confirmation titles and bounds alert-dialog height so actions remain reachable on constrained viewports.

  • Adds word wrapping to the two bot-name dialog titles.
  • Adds vertical overflow handling to shared alert-dialog content.
  • Extends E2E coverage and screenshot capture for the affected confirmation flows.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/web/src/pages/shell/dialogs.tsx Adds break-words to clear-conversation and delete-bot titles that interpolate user-defined bot names.
packages/ui-web/src/components/ui/alert-dialog.tsx Caps shared alert-dialog height and enables vertical scrolling for content taller than the viewport.
apps/web/e2e/bot-crud.spec.ts Renames the tested bot to a long unbroken name and scopes deletion assertions and interaction to its confirmation dialog.
apps/web/e2e/bot-organization.spec.ts Captures the clear-conversation confirmation state for screenshot-based E2E evidence.

Reviews (3): Last reviewed commit: "fix(web): keep delete dialog actions rea..." | Re-trigger Greptile

Rename to an 80-char unbroken bot name before Delete so CI screenshots
prove title wrapping, and snapshot the group Clear conversation dialog.

Co-authored-by: Elie Steinbock <elie222@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Playwright screenshots

Feature frames for this PR:

Open screenshot gallery · Dashboard · CI run

Updated for commit a791853.

Cap alert dialog height so tall titles can scroll, shorten the unbroken
bot-name E2E fixture so Delete stays in the Playwright viewport, and
scope the Delete click to the confirmation dialog.

Co-authored-by: Elie Steinbock <elie222@users.noreply.github.com>
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

@cursoragent is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

@elie222
elie222 merged commit 885142f into elie222:main Sep 7, 2026
16 of 17 checks passed
@RA-h
RA-h deleted the fix/delete-dialog-long-name branch September 7, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants