Repository navigation
fix(web): wrap long bot names in delete and clear dialogs - #765
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughDialog titles now wrap long bot names, and dialog content can scroll within a height limit. End-to-end tests cover long-name deletion and capture the clear-conversation confirmation dialog. ChangesLong bot name dialog coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Long unbroken bot names now remain within delete and clear-conversation dialogs, with oversized dialog content scrollable. The updated deletion flow coverage supports the intended behavior, with no remaining merge-readiness risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR makes long bot names wrap in clear and delete confirmation titles and bounds alert-dialog height so actions remain reachable on constrained viewports.
|
| Filename | Overview |
|---|---|
| apps/web/src/pages/shell/dialogs.tsx | Adds break-words to clear-conversation and delete-bot titles that interpolate user-defined bot names. |
| packages/ui-web/src/components/ui/alert-dialog.tsx | Caps shared alert-dialog height and enables vertical scrolling for content taller than the viewport. |
| apps/web/e2e/bot-crud.spec.ts | Renames the tested bot to a long unbroken name and scopes deletion assertions and interaction to its confirmation dialog. |
| apps/web/e2e/bot-organization.spec.ts | Captures the clear-conversation confirmation state for screenshot-based E2E evidence. |
Reviews (3): Last reviewed commit: "fix(web): keep delete dialog actions rea..." | Re-trigger Greptile
Rename to an 80-char unbroken bot name before Delete so CI screenshots prove title wrapping, and snapshot the group Clear conversation dialog. Co-authored-by: Elie Steinbock <elie222@users.noreply.github.com>
Playwright screenshotsFeature frames for this PR:
Open screenshot gallery · Dashboard · CI run Updated for commit |
Cap alert dialog height so tall titles can scroll, shorten the unbroken bot-name E2E fixture so Delete stays in the Playwright viewport, and scope the Delete click to the confirmation dialog. Co-authored-by: Elie Steinbock <elie222@users.noreply.github.com>
|
@cursoragent is attempting to deploy a commit to the Inbox Zero Team on Vercel. A member of the Team first needs to authorize it. |
Why
A bot with a very long unbroken name overflows the Delete confirmation dialog — the title runs past the dialog's right edge instead of wrapping.
What
How tested
Summary by CodeRabbit