Repository navigation
Drop support for preact - #896
Merged
Merged
Conversation
Codecov Report
|
Ailrun
reviewed
Oct 9, 2018
Ailrun
left a comment
Member
There was a problem hiding this comment.
emotion/packages/is-prop-valid/src/props.js
Lines 463 to 466 in 7ea1715
is also for Preact, isn't it?
Member
|
@Ailrun right, but at the moment is-prop-valid package is also used by other libraries (i.e. styled-components) and they expect preact support, considering that those are just 3 props, I would be in favour of keeping them here |
Member
Author
|
I agree with @Andarist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Remove all the preact packages and stuff in the build setup for it.
Why:
Supporting preact is getting impractical, it was easy in the past when there were very few differences in the react and preact APIs but as react has added new APIs like
createContext,forwardRefandFragment, it's getting significantly harder. While there are implementations of the new context API for preact, they aren't as performant as React'screateContextand they can't have some of the upcoming features likeunstable_readandstatic contextType = MyContext.(before anyone says preact is implementing x and y, this isn't just about the current APIs that are missing in preact, it's about future APIs that we couldn't fully utilize because we would still have to support preact) Also,preact-emotionhas significantly fewer downloads (~1k vs ~150k downloads a week) thanreact-emotionso the low demand for it doesn't justify the cost of maintaining it.Note that the
emotionpackage will still be usable with preact and if someone wants to maintain a separate implementation of styled for preact, I'd be happy to give up thepreact-emotionname on npm.How:
Checklist: