Repository navigation
add GPIO defines for C3 - #6005
Merged
Merged
Conversation
|
Hello, I changed the code to the code you updated, but the problem still appears. |
Collaborator
|
@GYSS1204 Try this complete Arduino framework. It is builded on latest IDF4.4 and latest Arduino master including this change. It does work with my C3. |
Member
|
I am a bit confused how this change helps (apart from maybe the adc init). For C3 |
Collaborator
|
@me-no-dev Perhaps it would simplify it if all architectures defined |
Member
|
@atanisoft that will have to be tested once we move all other peripherals to IDF API. It is the end goal though :) |
P-R-O-C-H-Y
reviewed
Dec 21, 2021
| } else if(mode == ANALOG){ | ||
| #if !CONFIG_IDF_TARGET_ESP32C3 | ||
| //adc_gpio_init(ADC_UNIT_1, ADC_CHANNEL_0); | ||
| adc_gpio_init(ADC_UNIT_1, ADC_CHANNEL_0); |
Member
There was a problem hiding this comment.
Is there any specific reason for uncommenting this line? :)
Don't have any effect on the esp32c3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: #5502 (comment)
Solution: tasmota#31 from @Jason2866