Repository navigation
fix(wm): don't tile user-minimized windows in the startup layout - #1834
Merged
Merged
Conversation
`TwmState::initialize` added every window of every workspace to the tree ignoring its minimized state, because windows on inactive workspaces are minimized by the virtual desktop manager to hide them and must keep their slot. On the active workspace, however, a minimized window was minimized by the user, and giving it a slot leaves an empty tile (with its border drawn by the overlay) on screen after every Seelen restart until something forces a re-render. Use the minimized-aware check for the active workspace of each monitor and keep the lenient one for the inactive ones. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StkifHpSLWH4J5TvuP56ur
Contributor
|
Contributor
|
I confirm, I constantly encounter this problem. |
eythaann
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
After Seelen UI (re)starts with some windows minimized, the tiling overlay shows empty tiles with their border drawn on the desktop: the layout reserves a slot for each minimized window. It stays like that until something forces a re-render (moving a window, toggling the window manager).
Reproduces every time: minimize a tiled window, restart Seelen UI.
Cause
TwmState::initializeadds every window of every persisted workspace to the tree withshould_be_managed_ignoring_minimized. That is right for inactive workspaces (the virtual desktop manager hides their windows by minimizing them, and they must keep their slot), but on the active workspace a minimized window was minimized by the user, and it gets a slot anyway.Fix
Use the minimized-aware
should_be_managedfor the active workspace of each monitor and keep the lenient check for the inactive ones.Tested
Debug build on Windows 11, two monitors: minimized Spotify, restarted Seelen; the remaining windows fill the layout and there is no empty tile.
cargo test, clippy and rustfmt clean.🤖 Generated with Claude Code