Skip to content

github copilot's fix - #1836

Merged
eythaann merged 10 commits into
eythaann:masterfrom
QRBG3376:qrbg3376-congenial-memory
Sep 20, 2026
Merged

eythaann merged 10 commits into
eythaann:masterfrom
QRBG3376:qrbg3376-congenial-memory

Conversation

@QRBG3376

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR appears safe to merge after the non-blocking Dock terminology issue is corrected.

Summary

This PR improves Simplified Chinese translations across the background service, settings, and several widgets.

  • Replaces literal or contextually incorrect translations with natural UI terminology.
  • Corrects labels for authentication, permissions, saving, power states, and application actions.
  • One apps-menu label confuses Seelen’s Dock with the Windows taskbar.

Reviews (1) · Last reviewed commit: "修正简体中文翻译:术语一致性与用词改进"

no_matching_items: 未找到与您的搜索相符的条目
open_file_location: 打开文件所在位置
pin: 固定
pin_to_dock: 固定到任务栏

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Dock mislabeled as taskbar

This label says “Pin to taskbar,” but the action emits WegAddItem to Seelen’s Dock. The Chinese settings use “任务栏” for the Windows taskbar and “Dock” for Seelen’s component, so users may expect the application to be pinned somewhere different from its actual destination. Please use the established Dock terminology here.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

@eythaann

Copy link
Copy Markdown
Owner

@QRBG3376 why u opened two PRs for translations instead just one? is this ready to merge?

@eythaann
eythaann merged commit a7cadc5 into eythaann:master Sep 20, 2026
1 check passed
@QRBG3376

QRBG3376 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor Author

那是因为和AI翻译时报黄了 @eythaann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants