Skip to content

i18n: overhaul and polish Vietnamese localization - #1927

Merged
eythaann merged 1 commit into
eythaann:masterfrom
chusaubanh:i18n/improve-vietnamese-translations
Oct 21, 2026
Merged

eythaann merged 1 commit into
eythaann:masterfrom
chusaubanh:i18n/improve-vietnamese-translations

Conversation

@chusaubanh

Copy link
Copy Markdown
Contributor

Summary

This PR overhauls and polishes the Vietnamese (vi) localization across the entire project (46 files).

Previously, many translations were literal machine translations that translated technical desktop concepts incorrectly or superficially (e.g., "Save" translated as "Cứu" [rescue], "Power" as "Quyền lực" [political power], "Window border" as "Biên giới" [national border], "Disabled" as "Tàn tật" [handicapped], "Volume" as "Khối lượng" [mass], "Toggle float/monocle" as "Phao / Một mắt", "Release key" as "Phát hành", etc.).

Changes

  • Settings UI (src/ui/react/settings/i18n/translations/vi.yml): Completely revised 480+ lines using standard desktop & Windows UI terminology.
  • Widgets (src/ui/svelte/*/i18n/translations/vi.yml): Corrected translations for Fancy Toolbar, Dock (Weg), Apps Menu, Quick Settings, Power Menu, Bluetooth, Network, Audio/Media, Notifications, User Menu, Icon Editor, Flyouts.
  • Background Core (src/background/i18n/vi.yml): Polished security, runtime, shortcut conflict, and permissions prompts.
  • Shortcuts & Display Names (src/static/widgets/): Fixed window manager, task switcher, workspaces viewer actions and descriptions.
  • Themes (src/static/themes/*/i18n/description.yml): Fixed descriptions for default and bubbles themes.

All YAML files have been verified for syntax validity.

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with one non-blocking shortcut-label correction.

Summary

Improves Vietnamese wording across settings, widgets, background prompts, and resource descriptions.

  • Vietnamese settings labels now describe desktop controls more clearly.
  • Vietnamese device controls now use clearer names for connections and sound.
  • Vietnamese app and dock menus now name their actions more clearly.
  • Vietnamese background messages now explain app prompts and warnings more clearly.
  • Vietnamese system menus and status messages now use clearer everyday wording.
  • Vietnamese icon and keyboard tools now use clearer labels.
  • Vietnamese widget, theme, and shortcut descriptions now use clearer desktop terms.

Reviews (2) · Last reviewed commit: "i18n: overhaul and polish Vietnamese loc..." · Reviewed by Greptile

Comment thread src/ui/react/settings/i18n/translations/vi.yml Outdated
Comment thread src/ui/react/settings/i18n/translations/vi.yml Outdated
Comment thread src/ui/react/settings/i18n/translations/vi.yml Outdated
@chusaubanh
chusaubanh force-pushed the i18n/improve-vietnamese-translations branch from d265458 to 8b69e29 Compare October 19, 2026 02:09
@eythaann
eythaann merged commit 7f05724 into eythaann:master Oct 21, 2026
1 check passed
ur: Monocle ٹوگل کریں۔
uz: Monokl-ni o'zgartirish
vi: Chuyển đổi một mắt
vi: Bật/Tắt chế độ toàn màn hình (Monocle)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Fullscreen label opens stacked layout

The Vietnamese label calls Monocle “toàn màn hình” (fullscreen), but this shortcut puts all tiled windows into one stack within the normal work area. With the toolbar or dock visible, windows still leave room for them. Use “chế độ một khung cửa sổ (Monocle)” instead so users do not mistake this for fullscreen.

Suggested change
vi: Bật/Tắt chế độ toàn màn hình (Monocle)
vi: Bật/Tắt chế độ một khung cửa sổ (Monocle)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants