Skip to content

fix: Preserve image layout during replay masking - #9344

Merged
philprime merged 5 commits into
mainfrom
philprime/fix/replay-bundle-image
Oct 14, 2026
Merged

philprime merged 5 commits into
mainfrom
philprime/fix/replay-bundle-image

Conversation

@philprime

Copy link
Copy Markdown
Member

Prevent Session Replay image redaction from changing archived images' rendered size. Replace the lazy image asset lookup and private bundle-property access with symbol detection and the image description's named( marker, preserving exemptions for bundled images and system symbols.

The description format is undocumented. If it changes, affected images default to being masked. Template rendering mode is not an exemption because these images can contain user content. Code comments explain these trade-offs.

Verification
The archived-image regression test failed before the fix and passes afterward. Formatting, static analysis, the iOS build, and 23 targeted redaction tests passed on iOS 18.4, including bundled-image, symbol, and anonymous-template coverage.

Refs #9314

The ignored-view short-circuit discussed in the issue is outside this PR's scope.

@philprime philprime self-assigned this Oct 14, 2026
@philprime philprime added the run-full-ci Allows gated GitHub Action workflows to run for a labelled pull request label Oct 14, 2026
@philprime
philprime marked this pull request as ready for review October 14, 2026 10:19
@philprime
philprime enabled auto-merge (squash) October 14, 2026 10:20
@sentry

sentry Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
SDK-Size io.sentry.sample.SDK-Size 9.30.1 (1) Release

⚙️ sentry-cocoa Build Distribution Settings

@sentry

sentry Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Size Analysis

1 component analyzed

iOS Builds

Name Configuration Version Download Size Install Size
SDK-Size (iOS)
io.sentry.sample.SDK-Size
Release 9.30.1 (1) 1.2 MB (+461 B) 3.2 MB (0 B)

Configure sentry-cocoa status check rules

@romtsn romtsn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.27 ms 1256.44 ms 41.17 ms
Size 24.14 KiB 1.39 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fee4ec3 1229.19 ms 1269.85 ms 40.66 ms
d9571ee 1225.67 ms 1259.02 ms 33.35 ms
b0aa013 1208.48 ms 1244.00 ms 35.52 ms
8a8e812 1233.65 ms 1257.19 ms 23.54 ms
1cba5c4 1230.28 ms 1271.48 ms 41.20 ms
f0e2408 1224.53 ms 1260.51 ms 35.98 ms
89ccfc2 1210.78 ms 1245.02 ms 34.24 ms
5e4b4ee 1210.02 ms 1260.08 ms 50.06 ms
545ca7e 1233.89 ms 1269.30 ms 35.41 ms
065705e 1217.35 ms 1253.04 ms 35.69 ms

App size

Revision Plain With Sentry Diff
fee4ec3 24.14 KiB 1.39 MiB 1.36 MiB
d9571ee 24.14 KiB 1.39 MiB 1.36 MiB
b0aa013 24.14 KiB 1.38 MiB 1.36 MiB
8a8e812 24.14 KiB 1.38 MiB 1.36 MiB
1cba5c4 24.14 KiB 1.38 MiB 1.36 MiB
f0e2408 24.14 KiB 1.39 MiB 1.36 MiB
89ccfc2 24.14 KiB 1.38 MiB 1.36 MiB
5e4b4ee 24.14 KiB 1.39 MiB 1.36 MiB
545ca7e 24.14 KiB 1.39 MiB 1.36 MiB
065705e 24.14 KiB 1.38 MiB 1.35 MiB

Previous results on branch: philprime/fix/replay-bundle-image

Startup times

Revision Plain With Sentry Diff
c64367b 1215.98 ms 1268.95 ms 52.97 ms

App size

Revision Plain With Sentry Diff
c64367b 24.14 KiB 1.39 MiB 1.36 MiB

@philprime
philprime merged commit 1ff5381 into main Oct 14, 2026
272 of 274 checks passed
@philprime
philprime deleted the philprime/fix/replay-bundle-image branch October 14, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved run-full-ci Allows gated GitHub Action workflows to run for a labelled pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants