Repository navigation
fix: Preserve image layout during replay masking - #9344
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
October 14, 2026 10:19
philprime
requested review from
NinjaLikesCheez,
itaybre and
noahsmartin
as code owners
October 14, 2026 10:19
philprime
enabled auto-merge (squash)
October 14, 2026 10:20
📲 Install BuildsiOS
|
Size Analysis1 component analyzed iOS Builds
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fee4ec3 | 1229.19 ms | 1269.85 ms | 40.66 ms |
| d9571ee | 1225.67 ms | 1259.02 ms | 33.35 ms |
| b0aa013 | 1208.48 ms | 1244.00 ms | 35.52 ms |
| 8a8e812 | 1233.65 ms | 1257.19 ms | 23.54 ms |
| 1cba5c4 | 1230.28 ms | 1271.48 ms | 41.20 ms |
| f0e2408 | 1224.53 ms | 1260.51 ms | 35.98 ms |
| 89ccfc2 | 1210.78 ms | 1245.02 ms | 34.24 ms |
| 5e4b4ee | 1210.02 ms | 1260.08 ms | 50.06 ms |
| 545ca7e | 1233.89 ms | 1269.30 ms | 35.41 ms |
| 065705e | 1217.35 ms | 1253.04 ms | 35.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fee4ec3 | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| d9571ee | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| b0aa013 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| 8a8e812 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| 1cba5c4 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| f0e2408 | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| 89ccfc2 | 24.14 KiB | 1.38 MiB | 1.36 MiB |
| 5e4b4ee | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| 545ca7e | 24.14 KiB | 1.39 MiB | 1.36 MiB |
| 065705e | 24.14 KiB | 1.38 MiB | 1.35 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent Session Replay image redaction from changing archived images' rendered size. Replace the lazy image asset lookup and private bundle-property access with symbol detection and the image description's
named(marker, preserving exemptions for bundled images and system symbols.The description format is undocumented. If it changes, affected images default to being masked. Template rendering mode is not an exemption because these images can contain user content. Code comments explain these trade-offs.
Verification
The archived-image regression test failed before the fix and passes afterward. Formatting, static analysis, the iOS build, and 23 targeted redaction tests passed on iOS 18.4, including bundled-image, symbol, and anonymous-template coverage.
Refs #9314
The ignored-view short-circuit discussed in the issue is outside this PR's scope.