Repository navigation
feat(client-reports): Record logs dropped by the logs buffer limit - #2322
Merged
Merged
Conversation
Co-Authored-By: Martin Linzmayer <martin.linzmayer@sentry.io>
Litarnus
approved these changes
Nov 6, 2026
This was referenced Nov 6, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
log_flush_thresholdis not set, logs are kept in a buffer of 1000. Once it's full, each new log pushes out the oldest one, which is never sent. This records each of those aslog_item/buffer_overflow.The buffer doesn't say when it drops an item, so the change compares the count before and after the push. A full buffer keeps the same count. An unbounded buffer (
log_flush_thresholdset) always grows, so it never records anything. The test fills the buffer, checks that nothing was recorded yet, then adds one more log.I used
buffer_overflowbecause the client reports spec defines it for SDK-internal buffers, and the span recorder limit (#2309) already uses it. The Python SDK records its log batcher overflow asqueue_overflowinstead.Part of #2228.
via Martin Linzmayer.
--
View Session [Sentry]