Repository navigation
feat(client-reports): Record profiles dropped for a missing OS context - #2326
Merged
Merged
Conversation
Co-Authored-By: Martin Linzmayer <martin.linzmayer@sentry.io>
Litarnus
approved these changes
Nov 6, 2026
This was referenced Nov 6, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2325: a profile is also discarded when the event has no valid OS context, which happens for example when the default integrations are disabled. This records that drop as
profile/insufficient_data, the spec reason for "lack of data in the event".One line in
Profile::getFormattedData()plus a test.ProfileItemalready removes a profile that can't be formatted from the event (#2325), so serializing twice for Spotlight doesn't count it twice.The other validation drops (runtime context, transaction/trace ID, duration, start time) are left for follow-ups.
Part of #2228.
via Martin Linzmayer.
--
View Session [Sentry]