Repository navigation
cmake : update semver and release process [no ci] - #3996
Merged
Merged
Conversation
This commit modifies the semantic version handling to be consistent with how llama.cpp and ggml handle semver. This commit introdues a new example named test-cmake which is intended to be used to test the cmake configuration and installation.
work in progress...
This is just for testing and this commit should not be included in the main PR later.
This commit updates the release and make-release workflows to use the DEPLOY_KEY_RELEASE secret. Two github ruleset have been imported.
These were retrived from llama.cpp and then imported into my fork for testing. If all works well they will be imported into whisper.cpp upstream as well.
This commit updated the example talk-llama to remove the vendored llama.cpp and instead use FetchContent to pull it in from the upstream repo.
This commit disables native CPU instructions from the ubuntu-22-clang job. The motivation for this is that currently it is possible that the running compiling llama.cpp (via ccache) might have support for cpu instructions that are not available on the target runner. Refs: https://github.com/ggml-org/whisper.cpp/actions/runs/32224048267/job/95980031403?pr=3996
This commit add attenstions of artifacts to the release workflow.
After building the artifacts can be verified with the following command:
```console
$ curl -sSL -o whisper-bin-ubuntu-x64.tar.gz \
https://github.com/danbev/whisper.cpp/releases/download/b4947/whisper-bin-ubuntu-x64.tar.gz
$ gh attestation verify --repo danbev/whisper.cpp whisper-bin-ubuntu-x64.tar.gz
Loaded digest sha256:722a6812263195d7ee2192b57fc64a6d6b09a6cdf2f55a152f793db27a651e31 for file://whisper-bin-ubuntu-x64.tar.gz
Loaded 1 attestation from GitHub API
The following policy criteria will be enforced:
- Predicate type must match:................ https://slsa.dev/provenance/v1
- Source Repository Owner URI must match:... https://github.com/danbev
- Source Repository URI must match:......... https://github.com/danbev/whisper.cpp
- Subject Alternative Name must match regex: (?i)^https://github\.com/danbev/whisper\.cpp/
- OIDC Issuer must match:................... https://token.actions.githubusercontent.com
✓ Verification succeeded!
The following 1 attestation matched the policy criteria
- Attestation #1
- Build repo:..... danbev/whisper.cpp
- Build workflow:. .github/workflows/release.yml@refs/heads/master
- Signer repo:.... danbev/whisper.cpp
- Signer workflow: .github/workflows/release.yml@refs/heads/master
```
This commit adds a new CMake option WHISPER_USE_SYSTEM_LLAMA that allows the talk-llama example to use a system-installed llama.cpp library. Setting this will automatically also set WHISPER_USE_SYSTEM_GGML to ON and the system ggml library will be used in addition to the system llama.cpp.
Member
Author
|
Attaching the script I used to test the system built llama.cpp and ggml with whisper-talk-llama: |
Member
Author
|
@ggerganov What are you thoughts about when developer builds should built? At the moment they are just manually built as I was not sure if we wanted to have the same cadence as llama.cpp and build for each push to master (conditioned on specific path contents). I know we had this a one point in the past but changed it which is why I'm a bit hesitant. But perhaps we should try this again and be consistent with llama.cpp. |
Member
|
I think it's OK to keep them manual for now. |
danbev
marked this pull request as ready for review
August 20, 2026 05:38
ggerganov
reviewed
Aug 20, 2026
ggerganov
approved these changes
Aug 20, 2026
Member
|
After we merge this, you can bump to |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains commits to update whisper.cpp's semantic versioning and release handling to be consistent with llama.cpp.
Currently the developer builds are manually triggered only. This is different from llama.cpp where every commit to master triggers a build. We had this once in the past in whisper.cpp but decided to change it.