Repository navigation
fix: mouse text selection broken by missing bottom-alignment padding - #175
Merged
Merged
Conversation
buffer_line_at_row() started visual_row at 0, but the viewport renders padding rows before content when auto-scrolled and content is shorter than the viewport. This caused clicks in the content area to be off by `pad` rows, so most clicks returned None and no selection was ever started. Now visual_row starts at `pad` to match the rendering offset.
Owner
|
Thank you, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Click-and-drag text selection in the chat viewport was broken — clicks on the content area returned `None` from `buffer_line_at_row()`, so no selection was ever started.
Root Cause
`buffer_line_at_row()` started `visual_row` at 0, but the viewport renders padding rows at the top before actual content when auto-scrolled and content is shorter than the viewport (bottom-alignment). This meant clicks in the content area were off by `pad` rows.
Fix
Start `visual_row` at `pad` (instead of 0) to match the rendering offset. Also hoisted the `pad` computation so it's available for both the early-return guard and the `visual_row` initial value.