Repository navigation
Fix edit & delete in the --setup screen - #252
Merged
Merged
Conversation
Edits and deletes in the manage screens mutate a local Config but then return KeyResult::Screen, which only swaps the screen and discards the Config -- the in-memory Ctx keeps the old value, so changes vanish before save_config runs on exit. Add a KeyResult::ApplyConfig(Screen, Config) variant that writes the mutated Config back into Ctx, and route the save and delete-confirmed branches through it. No-op navigation keeps using KeyResult::Screen. Also relabel the main-menu entry from "Q) Quit" to "Q) Quit & Save" to make the persist-on-exit behavior discoverable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix edit & save in the --setup screen. Noticed on first time use and I thought I was going crazy why it didn't save. 😀
Detailed description of the change in the commit message. I tried to keep the edit minimal.