Repository navigation
refactor: organize authentication domain - #4678
Merged
mnriem merged 1 commit intoSep 22, 2026
Merged
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The relocation is complete, internal references are consistent, and existing focused coverage follows the new module boundaries.
Review effort: Balanced
Findings: None
What changed in this PR
Moves GitHub HTTP utilities and authentication tests into the first-class authentication domain without changing behavior.
Changes:
- Migrates all consumers to
specify_cli.authentication.github_http. - Reorganizes authentication tests and shared helpers.
- Updates documentation and monkeypatch paths for the new structure.
| File | Description |
|---|---|
src/specify_cli/authentication/github_http.py |
Establishes the canonical domain module. |
src/specify_cli/bundles/sources.py |
Updates bundle download helper import. |
src/specify_cli/extensions/__init__.py |
Updates extension resolver import and documentation. |
src/specify_cli/presets/__init__.py |
Updates preset resolver import. |
src/specify_cli/presets/command_add.py |
Updates preset installation import. |
src/specify_cli/workflows/_commands.py |
Updates workflow catalog import. |
src/specify_cli/workflows/command_add.py |
Updates workflow installation import. |
tests/http_helpers.py |
Corrects the relocated test reference. |
tests/specify_cli/authentication/__init__.py |
Defines the authentication test package. |
tests/specify_cli/authentication/helpers.py |
Houses authentication-specific test helpers. |
tests/specify_cli/authentication/test_authentication.py |
Updates domain test terminology. |
tests/specify_cli/authentication/test_github_http.py |
Updates imports and monkeypatch targets. |
tests/test_extensions.py |
Uses the relocated authentication helper. |
tests/test_presets.py |
Uses the relocated authentication helper. |
tests/test_upgrade.py |
Uses the relocated authentication helper. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Organize authentication as a complete first-class domain package without treating it as a CLI command hierarchy.
specify_cli._github_httpintospecify_cli.authentication.github_httpand migrate repository consumers to the canonical domain path.tests/specify_cli/authentication/, preserving every existing authentication test function exactly once.This makes authentication source and test ownership consistent with other first-class domains while preserving runtime behavior and compatibility.
Testing
uv run specify --help.venv/bin/python -m pytest- 8,390 passed, 16 skipped (8,406 collected)uvx ruff@0.15.0 check src testsgit diff --checkAI Disclosure
AI disclosure: Posted on behalf of @mnriem by GitHub Copilot (model: GPT-5.6 Sol, autonomous); the structural code/test changes and this PR description were fully AI-drafted under user-directed scope and review.