Skip to content

Bump go versions to 1.18+ - #203

Merged
pohly merged 2 commits into
go-logr:masterfrom
thockin:bump_go_1_18
Aug 5, 2023
Merged

pohly merged 2 commits into
go-logr:masterfrom
thockin:bump_go_1_18

Conversation

@thockin

@thockin thockin commented Aug 4, 2023 •

Copy link
Copy Markdown
Contributor

Fixes #202

@thockin thockin mentioned this pull request Aug 4, 2023
3 of 4 tasks

@pohly pohly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do a search/replace for s/interface{}/any/, either in this PR or a separate one?

Or do we transition organically as code using interface{} gets touched?

Personally I prefer a global search/replace to keep the code base consistent.

@thockin

thockin commented Aug 4, 2023

Copy link
Copy Markdown
Contributor Author

Good idea, new commit added

@pohly
pohly merged commit 4c4e60e into go-logr:master Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump min Go version to at least 18?

2 participants