Repository navigation
CI: avoid floating dependencies, fix issues - #432
Merged
Merged
Conversation
The usage of apidiff@latest breaks from time to time, most recently because it requires Go 1.25 instead of the 1.24 configured in the GitHub action. By locking to a specific version we avoid that and a potential supply-chain attack. Dependabot gets configured to update the version of apidiff. If that PR fails, we need to fix it up manually before merging.
More recent golangci-lint again introduced new checks which broke the check of the existing code because of some false positives (?!). Those get ignored now, in addition to locking the version: - Prevents such random breakage in the future. - Reduces the risk of using a compromised new version.
Contributor
Author
|
/assign @thockin |
pohly
changed the title
Contributor
|
It looks like lint has decided to flag a bunch of long-standing behavior as wrong? I'm pretty sure when I wrote those tests that I didn't just blindly experiment, but I found something documented somewhere. |
Contributor
Author
It might be worth bringing this up as an issue in https://github.com/dominikh/go-tools/issues; maybe it's also dominikh/go-tools#1699. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage of apidiff@latest breaks from time to time, most recently because it requires Go 1.25 instead of the 1.24 configured in the GitHub action. By locking to a specific version we avoid that and a potential supply-chain attack.
Dependabot gets configured to update the version of apidiff. If that PR fails, we need to fix it up manually before merging.
Similar for golangci-lint: new checks can fail and we don't know what "latest" is. Unfortunately that version cannot be bumped by dependabot. It's said to be possible via "renovate", but configuring that seems overkill.