♻️ refactor: Rename benchmark cases - #4383
Conversation
WalkthroughTwo benchmark subtest names in ChangesBenchmark subtest naming
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the benchmark subtest names in path_test.go by replacing spaces and pipe characters with underscores, which improves compatibility with test runners and command-line tools. There are no review comments, and I have no additional feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4383 +/- ##
==========================================
- Coverage 91.38% 91.34% -0.05%
==========================================
Files 132 132
Lines 13108 13108
==========================================
- Hits 11979 11973 -6
- Misses 711 716 +5
- Partials 418 419 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thx |
Description
Currently, the Benchmark Markdown table is broken for the
Benchmark_Path_matchParamsandBenchmark_RoutePatternMatchbenchmarks (e.g., see https://github.com/gofiber/fiber/actions/runs/26518416331):It's because of the
|used in the test names that is interpreted as the table border in the Markdown. This PR replaces|with_to fix that.Changes introduced
List the new features or adjustments introduced in this pull request. Provide details on benchmarks, documentation updates, changelog entries, and if applicable, the migration guide.
Type of change
Please delete options that are not relevant.
Checklist
/docs/directory for Fiber's documentation.