Repository navigation
cmd/go: tool should explicitely reject an empty tool name #74757
Description
Go version
go version go1.24.5 darwin/arm64
Output of go env in your module/workspace:
GOROOT='/opt/homebrew/Cellar/go/1.24.5/libexec'What did you do?
$ go tool !
go: no such tool "!"
$ go tool ""
go tool : fork/exec /opt/homebrew/Cellar/go/1.24.5/libexec/pkg/tool/darwin_arm64: permission deniedWhat did you see happen?
The error message shows that the tool execution failure is caught by the OS which was given a directory path instead of a executable file path.
What did you expect to see?
go tool should reject much earlier such an invalid tool name and immediately fail with an error message.
$ go tool ""
go: no such tool ""
Activity
dolmen commentedon Jul 25, 2025
The implementation of tool lookup is in
cmd/go/internal/base.ToolandToolPath.dolmen commentedon Jul 25, 2025
Patch in progress...
gopherbot commentedon Jul 25, 2025
Change https://go.dev/cl/690435 mentions this issue:
cmd/go/internal/base: reject an empty tool namegabyhelp commentedon Jul 25, 2025
Related Issues
Related Code Changes
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
mknyszek commentedon Jul 25, 2025
CC @golang/command-line
cmd/go: reject an empty tool name