Skip to content

browser: fix flaky CI tests with a timeout bump - #5689

Merged
inancgumus merged 1 commit into
masterfrom
fix/getbyrole-context-bugs
Mar 9, 2026
Merged

browser: fix flaky CI tests with a timeout bump#5689
inancgumus merged 1 commit into
masterfrom
fix/getbyrole-context-bugs

Conversation

@inancgumus

@inancgumus inancgumus commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What?

Why?

  • The panic was because of cutting the test run short.
  • Tests (especially GetBy ones) just need more time (+5 minutes, more like ~20m).
  • This simple fix will tremendously solve many CI flakiness on its own.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

@inancgumus inancgumus self-assigned this Feb 20, 2026
@inancgumus
inancgumus changed the base branch from master to fix/test-browser-panic-on-nil-browser February 20, 2026 14:19
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 14:24 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 14:26 — with GitHub Actions Inactive
@inancgumus inancgumus changed the title browser: fix Context propagation in inner components browser: avoid rendering blockage due to timeouts Feb 20, 2026
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 18:57 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 18:58 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 21:41 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 21:42 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 21:59 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 22:12 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 20, 2026 22:13 — with GitHub Actions Inactive
@inancgumus
inancgumus force-pushed the fix/getbyrole-context-bugs branch from 2c04680 to 1ebdfa7 Compare February 24, 2026 19:12
@inancgumus
inancgumus changed the base branch from fix/test-browser-panic-on-nil-browser to master February 24, 2026 19:13
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 19:19 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 19:20 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 20:13 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 20:15 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 20:34 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 20:36 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 20:53 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:00 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:07 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:14 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:16 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:28 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:30 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:54 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 24, 2026 21:56 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 25, 2026 01:26 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 25, 2026 06:36 — with GitHub Actions Inactive
@inancgumus
inancgumus force-pushed the fix/getbyrole-context-bugs branch from c4a6322 to 239a207 Compare February 25, 2026 12:16
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 25, 2026 12:22 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 25, 2026 12:24 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 25, 2026 21:01 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 25, 2026 21:03 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 26, 2026 05:13 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 26, 2026 05:15 — with GitHub Actions Inactive
@inancgumus
inancgumus force-pushed the fix/getbyrole-context-bugs branch 2 times, most recently from cac021a to 7ab9774 Compare February 26, 2026 05:36
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 26, 2026 05:42 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 26, 2026 05:45 — with GitHub Actions Inactive
@inancgumus
inancgumus force-pushed the fix/getbyrole-context-bugs branch from 7ab9774 to 239a207 Compare February 26, 2026 06:50
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 26, 2026 06:57 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing February 26, 2026 06:58 — with GitHub Actions Inactive
@inancgumus inancgumus added this to the v1.7.0 milestone Mar 6, 2026
@inancgumus
inancgumus force-pushed the fix/getbyrole-context-bugs branch from 239a207 to 364103b Compare March 6, 2026 18:27
@inancgumus
inancgumus marked this pull request as ready for review March 6, 2026 18:28
@inancgumus
inancgumus requested a review from a team as a code owner March 6, 2026 18:28
@inancgumus
inancgumus requested review from ankur22 and szkiba and removed request for a team March 6, 2026 18:28
@inancgumus inancgumus changed the title browser: avoid rendering blockage due to timeouts browser: fix flaky CI tests with a timeout bump Mar 6, 2026
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing March 6, 2026 18:34 — with GitHub Actions Inactive
@inancgumus
inancgumus temporarily deployed to azure-trusted-signing March 6, 2026 18:36 — with GitHub Actions Inactive
@inancgumus
inancgumus merged commit 4b9e60d into master Mar 9, 2026
56 of 57 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2026
Merged

This branch was previously deployed

1 inactive deployment
azure-trusted-signing — 364103b1 Deployed Mar 6, 2026 by inancgumus via sign-packages #8480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankur22 ankur22 ankur22 approved these changes
@szkiba szkiba szkiba approved these changes

Assignees

@inancgumus inancgumus

Labels

None yet

Projects

None yet

Milestone

v1.7.0

Development

Successfully merging this pull request may close these issues.

GetBy tests are flaky on CI

3 participants

@inancgumus @ankur22 @szkiba