Repository navigation
Backport Sobek update to v1.x - #6280
Merged
Merged
Conversation
mstoykov
requested review from
inancgumus and
joanlopez
and removed request for
a team
August 12, 2026 09:51
mstoykov
temporarily deployed
to
azure-trusted-signing
August 12, 2026 09:57 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
mstoykov
temporarily deployed
to
azure-trusted-signing
August 12, 2026 10:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mstoykov
temporarily deployed
to
azure-trusted-signing
August 12, 2026 10:05 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Masterminds/semver v3.5.0 changed the error message for invalid constraints to quote the constraint value (e.g. `"+1.4.0"` instead of `+1.4.0`). Update the test to match the new format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mstoykov
temporarily deployed
to
azure-trusted-signing
August 12, 2026 12:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mstoykov
temporarily deployed
to
azure-trusted-signing
August 12, 2026 12:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
joanlopez
approved these changes
Aug 12, 2026
inancgumus
approved these changes
Aug 12, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backport the Sobek dependency update from master to v1.x.
Changes
github.com/grafana/sobektov0.0.0-20260727154728-7781506a890f.go.sumand the vendored dependencies.Additional update required
Sobek now requires Masterminds/semver v3.5.0. That version quotes invalid constraint values in error messages, so the v1.x test expectation also needs to be updated from
improper constraint: +1.4.0toimproper constraint: "+1.4.0". This matches the change already made on master in df94e5d.Verification
go test -mod=vendor ./internal/js ./lib/netext/httpextgo test ./internal/cmd -run "^TestProcessUseDirectives$/constraint_bad_format$" -count=1The previously failing constraint-format test now passes.