Skip to content

Update Sobek and expand TC39 coverage - #6382

Merged
mstoykov merged 1 commit into
masterfrom
updateSobek
Sep 11, 2026
Merged

mstoykov merged 1 commit into
masterfrom
updateSobek

Conversation

@mstoykov

@mstoykov mstoykov commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

What?

  • Update github.com/grafana/sobek to 4698bc773ae7.
  • Update and vendor github.com/dlclark/regexp2/v2 v2.7.2.
  • Remove 31 TC39 expected failures fixed by the Sobek update.
  • Enable TC39 coverage for:
    • uint8array-base64
    • set-methods
    • String.prototype.replaceAll
    • logical-assignment-operators
    • regexp-named-groups
  • Record the six remaining named-group edge-case failures instead of blocklisting the entire feature.

Why?

The updated Sobek version adds new JavaScript functionality and fixes several existing conformance failures. Enabling the corresponding Test262 suites ensures that k6 exercises these features and detects future regressions.

Testing

  • go mod verify
  • go test -count=1 ./internal/js/tc39
  • go test -count=1 ./internal/js/...
    • All non-browser packages passed.
    • Browser tests could not run successfully because Chromium access is restricted by the local sandbox.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Related PR(s)/Issue(s)

@mstoykov
mstoykov requested a review from a team as a code owner September 8, 2026 15:01
@mstoykov
mstoykov requested review from ankur22 and szkiba and removed request for a team September 8, 2026 15:01
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing September 8, 2026 15:08 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing September 8, 2026 15:10 — with GitHub Actions Inactive
@mstoykov mstoykov added this to the v2.3.0 milestone Sep 11, 2026
@mstoykov
mstoykov merged commit c204bdf into master Sep 11, 2026
64 of 72 checks passed
@mstoykov
mstoykov deleted the updateSobek branch September 11, 2026 13:29

This branch was previously deployed

1 inactive deployment
azure-trusted-signing — e52633e1 Deployed Sep 8, 2026 by mstoykov via sign-packages #10567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants