Conversation
6 tasks
uberbrady
changed the title
Member
|
What are the reservations on this one? Also please provide a test |
uberbrady
marked this pull request as ready for review
February 19, 2026 11:23
Member
Author
|
@snipe I hot-fixed the customer and asked them directly if this made the problem go away - and they've now confirmed that it did make the problem go away, so this change should be good. If you want to hold off until I have a test, I can do that. |
Member
|
@uberbrady Thanks for confirming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FMCS it's possible that the original admin who did a checkout isn't in the same company as the admin who might be trying to re-send the acceptance request. In this case, the 3rd parameter can come across as
null- which violates the type constraint in the function definition.This loosens that up to allow a
null. The view part of the blade was already null-safe.Fixes #18571