Fixes (hopefully) RB #19772 Unexpected EOF - #18614
Merged
Merged
Conversation
Member
|
Damn, nice find - weird that it seems to only cause issues sometimes. |
Collaborator
Author
|
I imagine because of the nature of conditions it's only going to early end the file in certain scenarios? |
Member
|
But, like, on the customer who generated the RB, I couldn't reproduce it there either. ¯_(ツ)_/¯ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds a semicolon I noticed was missing, which actually has a conditional statement right after it in the blade so could explain the unexpected end of file error we received from rollbar. A little bit of a shot in the dark, but definitely shouldn't harm anything.