Skip to content

Fixed asset maintenances page not rendering with missing asset - #19021

Merged
snipe merged 1 commit into
grokability:developfrom
marcusmoore:fixes/21081-missing-asset-in-maintenance
May 13, 2026
Merged

snipe merged 1 commit into
grokability:developfrom
marcusmoore:fixes/21081-missing-asset-in-maintenance

Conversation

@marcusmoore

Copy link
Copy Markdown
Collaborator

If an asset does not exist for the ID that an asset maintenance record has then the maintenance page would not render. This PR fixes that.

image

[RB-21081]
[RB-21082]
[RB-21083]

@marcusmoore
marcusmoore requested a review from snipe as a code owner May 13, 2026 17:14
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@snipe

snipe commented May 13, 2026

Copy link
Copy Markdown
Member

Doesn't exist as in soft-deleted, or ferreal doesn't exist? I don't think we'd want to hide that maintenance - it did exist at some point.

@marcusmoore

Copy link
Copy Markdown
Collaborator Author

Soft deleted models are already handled:

image

This is "for real doesn't exist". I'll mark this as draft and make an update.

@marcusmoore
marcusmoore marked this pull request as draft May 13, 2026 17:40
@marcusmoore

Copy link
Copy Markdown
Collaborator Author

@snipe I know this came up for the unaccepted assets before and it looks like we completely remove the entry if the asset related to the CheckoutAcceptance does not exist.

My original change follows that behavior. Would you like to keep it as is or should I update it here?

@snipe

snipe commented May 13, 2026

Copy link
Copy Markdown
Member

I think it's probably fine as-is, thank you!

@marcusmoore
marcusmoore marked this pull request as ready for review May 13, 2026 18:24
@snipe
snipe merged commit afb7c69 into grokability:develop May 13, 2026
9 checks passed
@marcusmoore
marcusmoore deleted the fixes/21081-missing-asset-in-maintenance branch May 18, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants