Fix incorrect ATT&CK report messages - #1483
Merged
Merged
Conversation
mapped to its config fields
they make more sense
…t it's shown in the config instead of the ATT&CK report
specific systems And remove hardcoded "since it didn't run on any ... systems" from the unscanned message for those techniques
…nd declare it for all techniques left
cc/services/attack/technique_reports/ See https://stackoverflow.com/a/58321197/10629482.
1. not run on relevant system 2. relevant config options were disabled
mssalvatore
requested changes
Sep 23, 2021
mssalvatore
left a comment
mssalvatore
left a comment
Collaborator
There was a problem hiding this comment.
I think this provides a lot of good, useful information to the user. Good job!
We're missing some unit tests and I think a lot of the new logic can be simplified. Any time your checking if key in dict:, you can probably simplify by using dict.get() or dict.setdefault().
ilija-lazoroski
left a comment
ilija-lazoroski
left a comment
Contributor
There was a problem hiding this comment.
Two of the swimm units are outdated. Needs to be changed.
-
Add details about your new PBA (JFXftJml8DpmuCPBA9rL) .
-
Add a new System Info Collector (OwcKMnALpn7tuBaJY1US) .
Otherwise, good job!!
Collaborator
|
This should also get a changelog entry. |
`get_config_schema_per_attack_technique()` in config_schema_per_attack_technique.py
`_add_config_field_to_reverse_schema()` in config_schema_per_attack_technique.py
config_schema_per_attack_technique.py
monkey_island\cc\services\attack\technique_reports\__init__.py
test_technique_reports.py
code in test_technique_reports.py
Codecov Report
@@ Coverage Diff @@
## develop #1483 +/- ##
===========================================
+ Coverage 41.59% 42.83% +1.24%
===========================================
Files 461 471 +10
Lines 13953 14354 +401
===========================================
+ Hits 5804 6149 +345
- Misses 8149 8205 +56
Continue to review full report at Codecov.
|
mssalvatore
requested changes
Sep 27, 2021
…of generating reverse schema at runtime
…le instead of generating it every time
Co-authored-by: Mike Salvatore <mike.s.salvatore@gmail.com>
mssalvatore
requested changes
Sep 27, 2021
mssalvatore
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #919.
See commit messages for details.
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist