Skip to content

Remove export_monkey_telems - #2013

Merged
VakarisZ merged 7 commits into
developfrom
1998-remove-export_monkey_telems
Jun 13, 2022
Merged

VakarisZ merged 7 commits into
developfrom
1998-remove-export_monkey_telems

Conversation

@shreyamalviya

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #1998

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@shreyamalviya
shreyamalviya force-pushed the 1998-remove-export_monkey_telems branch from b1b26ae to 4947e54 Compare June 10, 2022 19:13
@codecov

codecov Bot commented Jun 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2013 (4947e54) into develop (825f559) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2013      +/-   ##
===========================================
+ Coverage    56.62%   56.63%   +0.01%     
===========================================
  Files          465      463       -2     
  Lines        12965    12894      -71     
===========================================
- Hits          7341     7303      -38     
+ Misses        5624     5591      -33     
Impacted Files Coverage Δ
monkey/common/config_value_paths.py 100.00% <ø> (ø)
monkey/infection_monkey/config.py 34.78% <ø> (-1.39%) ⬇️
monkey/monkey_island/cc/resources/log.py 54.54% <ø> (-1.98%) ⬇️
monkey/monkey_island/cc/resources/monkey.py 29.41% <ø> (-1.36%) ⬇️
monkey/monkey_island/cc/resources/telemetry.py 32.72% <ø> (-1.21%) ⬇️
monkey/monkey_island/cc/services/config.py 86.56% <ø> (+0.22%) ⬆️
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)
...y/monkey_island/cc/services/infection_lifecycle.py 64.28% <ø> (+1.24%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825f559...4947e54. Read the comment docs.

@VakarisZ
VakarisZ merged commit 3598b0d into develop Jun 13, 2022
@VakarisZ
VakarisZ deleted the 1998-remove-export_monkey_telems branch June 13, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove export_monkey_telems from the configuration

3 participants