homebridge-somfy-tahoma-screen #694

Activity

1. Luligu

   added

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Feb 21, 2024
2. github-actions commented on Feb 21, 2024

   

   github-actionsBot

   on Feb 21, 2024 – with GitHub Actions

   Contributor

   More actions

   The following pre-checks failed:

   ❌ Failed to import plugin: Cannot find package 'hap-nodejs' imported from /workspace/test-area/node_modules/homebridge-somfy-tahoma-screen/dist/hapCustom.js

   Comment /check to run checks again.
3. Luligu commented on Feb 21, 2024

   

   Luligu

   on Feb 21, 2024

   Author

   More actions

   /check
4. github-actions commented on Feb 21, 2024

   

   github-actionsBot

   on Feb 21, 2024 – with GitHub Actions

   Contributor

   More actions

   ✅ Pre-checks completed successfully.
5. bwp91 commented on Mar 17, 2024

   

   bwp91

   on Mar 17, 2024

   Contributor

   More actions

   Hi @Luligu

   The plugin causes a crash-and-restart loop with the following configuration:

           {
               "name": "Somfy TaHoma Screen",
               "service": "somfy_europe",
               "platform": "Somfy TaHoma Screen",
               "_bridge": {
                   "username": "0E:8E:B2:67:DA:64",
                   "port": 31838
               }
           }
   

   In fact this is the config that is saved when opening the plugin UI the first time and clicking save straight away (apart from the _bridge section).

   [15:45:39.597] [Somfy TaHoma Screen] Finished initializing platform: Somfy TaHoma Screen 
   [15:45:39.963] [Somfy TaHoma Screen] Executed didFinishLaunching callback 
   [17/03/2024, 15:45:40] Homebridge v1.7.1-beta.24 (HAP v0.11.2) (Somfy TaHoma Screen) is running on port 31838.
   
   /usr/local/lib/node_modules/homebridge-somfy-tahoma-screen/node_modules/overkiz-client/src/ApiClient.ts:79
                   throw new Error('Invalid credentials provided');
                         ^
   Error: Invalid credentials provided
       at CloudApiClient.connect (/usr/local/lib/node_modules/homebridge-somfy-tahoma-screen/node_modules/overkiz-client/src/ApiClient.ts:79:23)
       at OverkizClient.connect (/usr/local/lib/node_modules/homebridge-somfy-tahoma-screen/node_modules/overkiz-client/src/Client.ts:118:25)
       at SomfyTaHomaBridgePlatform.discoverDevices (file:///usr/local/lib/node_modules/homebridge-somfy-tahoma-screen/src/platform.ts:71:29)
       at Timeout._onTimeout (file:///usr/local/lib/node_modules/homebridge-somfy-tahoma-screen/src/platform.ts:56:20)
       at listOnTimeout (node:internal/timers:573:17)
       at processTimers (node:internal/timers:514:7)
   [17/03/2024, 15:45:41] [Somfy TaHoma Screen] Child bridge process ended
   

   The plugin should log its errors but not cause the process to terminate.
6. bwp91

   added

   awaiting-changesuse after review has started - awaiting user to make changes to pluginuse after review has started - awaiting user to make changes to plugin

   and removed

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Mar 17, 2024
7. Luligu commented on Mar 19, 2024

   

   Luligu

   on Mar 19, 2024

   Author

   More actions

   Hi,
   you are right thanks.

   Release 1.0.14:
   Fixed:

   • check platform config for undefined username and password;
   • added try catch to TaHoma client platform calls (this will fix both wrong credentials and any possible error with the TaHoma client).
8. bwp91

   added

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxesuse for starting a review - adds a comment with the verification list with empty checkboxes

   and removed

   awaiting-changesuse after review has started - awaiting user to make changes to pluginuse after review has started - awaiting user to make changes to plugin

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Mar 25, 2024
9. github-actions commented on Mar 25, 2024

   

   github-actionsBot

   on Mar 25, 2024 – with GitHub Actions

   Last edited by bwp91

   Contributor

   More actions

   • General
     • The plugin must be of type dynamic platform.
     • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
   • Repo
     • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
     • A GitHub release should be created for every new version of your plugin, with release notes.
   • Environment
     • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
     • The plugin must successfully install and not start unless it is configured.
     • The plugin must not execute post-install scripts that modify the users' system in any way.
     • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
   • Codebase
     • The plugin must implement the Homebridge Plugin Settings GUI.
     • The plugin must not contain any analytics or calls that enable you to track the user.
     • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
     • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

   ---

   ---

   Comment /check to run checks again.
10. bwp91 commented on Mar 25, 2024

    

    bwp91

    on Mar 25, 2024

    Contributor

    More actions

    Why do you use a different date/time format for the logs?

    
11. bwp91

    added

    reviewed

    verifieduse when a plugin meets the criteria - adds the verified badge textuse when a plugin meets the criteria - adds the verified badge text

    and removed

    currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxesuse for starting a review - adds a comment with the verification list with empty checkboxes

    reviewed

    on Mar 26, 2024
12. github-actions commented on Mar 26, 2024

    

    github-actionsBot

    on Mar 26, 2024 – with GitHub Actions

    Contributor

    More actions

    • General
      • The plugin must be of type dynamic platform.
      • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
    • Repo
      • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
      • A GitHub release should be created for every new version of your plugin, with release notes.
    • Environment
      • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
      • The plugin must successfully install and not start unless it is configured.
      • The plugin must not execute post-install scripts that modify the users' system in any way.
      • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
    • Codebase
      • The plugin must implement the Homebridge Plugin Settings GUI.
      • The plugin must not contain any analytics or calls that enable you to track the user.
      • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
      • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

    ---

    Everything Looks Good!
13. github-actions commented on Mar 26, 2024

    

    github-actionsBot

    on Mar 26, 2024 – with GitHub Actions

    Contributor

    More actions

    Congratulations! Your plugin has been verified.

    You can now add one of the Verified by Homebridge badges to your plugin's README:

    

    [![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)
    

    

    [![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)
    

    Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

    If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

    Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

    Thank you for your contribution to the Homebridge Community.
    https://homebridge.io
14. bwp91

    closed this as completedon Mar 26, 2024