Skip to content

support target keyword in instantiate API - #1673

Merged
jieru-hu merged 1 commit into
hydra-ecosystem:masterfrom
jieru-hu:1669
Jun 17, 2021
Merged

jieru-hu merged 1 commit into
hydra-ecosystem:masterfrom
jieru-hu:1669

Conversation

@jieru-hu

Copy link
Copy Markdown
Contributor

Closes #1669

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2021
@jieru-hu
jieru-hu requested review from Jasha10 and omry June 15, 2021 19:35

@Jasha10 Jasha10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@omry omry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jieru-hu
jieru-hu merged commit 52905a6 into hydra-ecosystem:master Jun 17, 2021
@jieru-hu
jieru-hu deleted the 1669 branch July 20, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Cannot use target kwarg when instantiating with hydra.utils.instantiate()

4 participants