Skip to content

improve error msg when handling OmegaConfBaseException in config_loader - #1824

Merged
Jasha10 merged 4 commits into
hydra-ecosystem:mainfrom
Jasha10:closes1697_2
Sep 16, 2021
Merged

Jasha10 merged 4 commits into
hydra-ecosystem:mainfrom
Jasha10:closes1697_2

Conversation

@Jasha10

@Jasha10 Jasha10 commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Closes #1697

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2021
@Jasha10
Jasha10 requested a review from jieru-hu September 15, 2021 09:01
@omry

omry commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator

Nice.

Since this is an enhancement, I think it should probably go toward Hydra 1.2.
At this point, the main branch is still Hydra 1.1, so it would make sense to create a release branch for 1.1 and freeze it (before merging this).

@Jasha10
Jasha10 merged commit f147d1b into hydra-ecosystem:main Sep 16, 2021
@Jasha10
Jasha10 deleted the closes1697_2 branch September 16, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message for merging from defaults list

3 participants