Skip to content

multirun works with hydra.verbose=True - #1976

Merged
jieru-hu merged 1 commit into
hydra-ecosystem:mainfrom
jieru-hu:i1897
Jan 19, 2022
Merged

jieru-hu merged 1 commit into
hydra-ecosystem:mainfrom
jieru-hu:i1897

Conversation

@jieru-hu

@jieru-hu jieru-hu commented Jan 19, 2022 •

Copy link
Copy Markdown
Contributor

closes #1897

when hydra.verbose=True, the Hydra app will log all the debug info, in particular this will be called. However, we hard coded all the run mode to be RUN for printing out debug info. This means the command line overrides in this case (a=1,2) cannot be parsed correctly since the mode is set to RUN instead of MULTIRUN.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2022
@jieru-hu
jieru-hu marked this pull request as ready for review January 19, 2022 23:05
@jieru-hu
jieru-hu requested review from Jasha10 and pixelb January 19, 2022 23:05

@pixelb pixelb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jieru-hu
jieru-hu merged commit 30ec635 into hydra-ecosystem:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?] multirun does not work with hydra.verbose=True

3 participants