Skip to content

fix(web): count antigravity accounts in account list - #870

Merged
SsuJojo merged 2 commits into
devfrom
fix/antigravity-account-empty-state
Oct 14, 2026
Merged

SsuJojo merged 2 commits into
devfrom
fix/antigravity-account-empty-state

Conversation

@SsuJojo

@SsuJojo SsuJojo commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Problem

The dashboard account section rendered 「暂无已连接的账户」 and a 0 / 0 header count while an Antigravity account was connected and its card was on screen.

App.tsx renders <AntigravityAccounts> as a section of its own next to <AccountList>, but AccountList only ever inspected its own Codex pool: the empty state was driven by displayAccounts.length === 0, and the header / filter counts by accounts.length.

Change

  • AccountList now accepts the Antigravity pool (antigravityAccounts?) and folds it into the header totals and the "all" filter count.
  • The noAccounts empty state is withheld while an Antigravity account exists. A Codex status filter that matches nothing keeps its own noMatchingAccounts hint.
  • App.tsx passes accounts.antigravityAccounts into the list.
  • Status-specific filters stay Codex-scoped: Antigravity accounts are never hidden by a Codex status, so they only add to the "all" bucket.

Verification

  • Web suite in the branch worktree: 14 files / 62 tests passed.
  • Root tests/unit/web: 12 files / 58 tests passed.
  • Pre-fix control: with AccountList.tsx and App.tsx stashed, all four new tests fail; with the fix, all pass.
  • vite build succeeds.
  • tsc --noEmit -p web/tsconfig.json reports only the two pre-existing "confirm" translation-key errors (web/src/components/AddAccount.tsx:356, web/src/components/AntigravityAccounts.tsx:90), both untouched by this PR.

Notes

PR #868 (feat-antigravity-oauth-accounts) relocates these same Antigravity cards into AccountList. This fix targets current dev and is deliberately small; whichever of the two lands second needs a small reconcile in AccountList.tsx.

The dashboard renders the Antigravity accounts in a section of their own
next to the Codex account list, but the list only ever looked at its own
pool. A setup whose only connected account was an Antigravity account
therefore still showed the "no accounts connected" empty state and a
0 / 0 header count while the Antigravity card was on screen.

Feed the Antigravity pool into the account list so the header totals and
the "all" filter count cover both pools, and withhold the empty state
while an Antigravity account is connected. Status filters stay
Codex-scoped because Antigravity accounts are never hidden by a Codex
status.
@SsuJojo
SsuJojo merged commit 7d2751c into dev Oct 14, 2026
5 checks passed
@SsuJojo
SsuJojo deleted the fix/antigravity-account-empty-state branch October 14, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant