Skip to content

feat: add country boundaries file to image - #80

Merged
zackpollard merged 2 commits into
immich-app:mainfrom
pokjay:feat/add-country-boundaries-file
Jul 17, 2024
Merged

zackpollard merged 2 commits into
immich-app:mainfrom
pokjay:feat/add-country-boundaries-file

Conversation

@pokjay

@pokjay pokjay commented Jul 7, 2024 •

Copy link
Copy Markdown
Contributor

Add country boundaries file to image. A geoJSON file containing boundary polygons for each country from Natural Earth.

Will be used for geocoding images with remote locations which the current cities geocoding fails: immich-app/immich#10950

Built and tested locally.

@zackpollard

zackpollard commented Jul 7, 2024 •

Copy link
Copy Markdown
Member

I appreciate that this may be time consuming to compute, but I would want to understand
1.) how we compute this file and
2.) have the scripts for doing that in this repo and the transformations generated within this repo or another repo in the Immich org.

We can almost certainly do this on a schedule in a GitHub actions runner, so I'd prefer we do that than just link out to another users repo to pull the file.

If I've misunderstood how this works then I am happy to be corrected, I thought there was some preprocessing required we couldn't do on the Immich database

@pokjay

pokjay commented Jul 7, 2024

Copy link
Copy Markdown
Contributor Author

I appreciate that this may be time consuming to compute, but I would want to understand 1.) how we compute this file and 2.) have the scripts for doing that in this repo and the transformations generated within this repo or another repo in the Immich org.

We can almost certainly do this on a schedule in a GitHub actions runner, so I'd prefer we do that than just link out to another users repo to pull the file.

If I've misunderstood how this works then I am happy to be corrected, I thought there was some preprocessing required we couldn't do on the Immich database

After the last discussion and with bo0tzz idea I relooked at it, and there's actually no need for any preprocessing!
I use the official Github repo of the Natural Earth project, and they store a geoJSON file with the country boundaries. This is easy to read and load to the DB, which is what I do in the other PR.

(You can see in https://www.naturalearthdata.com/about/contact-us/ that nvkelso is/was a Project Manager in Natural Earth)

@zackpollard
zackpollard enabled auto-merge (squash) July 17, 2024 20:12
@zackpollard
zackpollard disabled auto-merge July 17, 2024 20:12
@zackpollard zackpollard changed the title feat: Add country boundaries file to image feat: add country boundaries file to image Jul 17, 2024
@zackpollard
zackpollard enabled auto-merge (squash) July 17, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants