Skip to content

feat(mobile): add support for material themes - #11560

Merged
alextran1502 merged 6 commits into
immich-app:mainfrom
pruthvi-21:mobile/material-theming
Aug 6, 2024
Merged

alextran1502 merged 6 commits into
immich-app:mainfrom
pruthvi-21:mobile/material-theming

Conversation

@pruthvi-21

Copy link
Copy Markdown

Added support for custom theming.



With color interface turned on, primary color will be applied to the backgrounds.



In Android, we can use system color

Added support for custom theming and updated all elements accordingly.
@moritzbindewald

Copy link
Copy Markdown

❤️

@alextran1502

alextran1502 commented Aug 5, 2024 •

Copy link
Copy Markdown
Member

Hello, thank you for the PR. Can you please have the default color as the current color used? It is the branding color of Immich.

Additionally, can we restore the original font weight of the design?

@pruthvi-21

Copy link
Copy Markdown
Author

Hi @alextran1502, actually the ColorScheme class adjusted the contrast of those colors based on light/dark mode. Now, I've overridden those with Immich brand logo colors fetched from the website.

And, what font weights are you referring to?

Also, when turning of the colorful interface do we want dark background or a black background?

@alextran1502

Copy link
Copy Markdown
Member

@pruthvi-21 thank you for the quick addressing of the comments.

I am seeing the font weight's changes of the text from the Settings page

@alextran1502

Copy link
Copy Markdown
Member

Can you preserve the shading of all the components? For example, the bottom app bar and the top bar background color now have a light gray shade, which creates a more confined feeling of the actual screen space of the timeline.

@pruthvi-21

pruthvi-21 commented Aug 5, 2024 •

Copy link
Copy Markdown
Author

I believe the bottom navigation bar has always been gray. As for the top bar, it dynamically changes color when the user scrolls through the timeline, which is the default behavior and gives the app a more modern feel.

Do you want a static color instead of this ?

Edit: Also, we can't use static colors now. as we need to pull every color from generated ColorScheme of each theme.

@alextran1502

Copy link
Copy Markdown
Member

I believe the bottom navigation bar has always been gray. As for the top bar, it dynamically changes color when the user scrolls through the timeline, which is the default behavior and gives the app a more modern feel.

This is not correct. You can see how it works in the release version. I understand that it dynamically changes the color, and we don't want it to change the color because we don't want to create a separation feeling of the top/bottom bar, which will narrow the perceived field of view of the actual available content.

Please change the color and leave all the other behavior/styling as is.

@pruthvi-21

Copy link
Copy Markdown
Author

@alextran1502 like this?

@alextran1502

Copy link
Copy Markdown
Member

Yes, is the stop bar still changing color when scroll?

@pruthvi-21

Copy link
Copy Markdown
Author

no it won't change now.

@alextran1502 alextran1502 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a lot of good changes, thank you very much!

@alextran1502
alextran1502 enabled auto-merge (squash) August 6, 2024 14:10
@alextran1502
alextran1502 merged commit 0eacdf9 into immich-app:main Aug 6, 2024
@pruthvi-21

pruthvi-21 commented Aug 6, 2024 •

Copy link
Copy Markdown
Author

@alextran1502 did you set the immich logo color in immich_app_bar.dart to only use the brand colors? if so, we also need to set in login page and app_bar_dialog for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants