Repository navigation
feat: change web asset detail map to zoom level 12.5 - #11643
Merged
Merged
Conversation
danieldietzler
approved these changes
Aug 7, 2024
alextran1502
approved these changes
Aug 7, 2024
jrasm91
approved these changes
Aug 7, 2024
jrasm91
left a comment
jrasm91
left a comment
Member
There was a problem hiding this comment.
I'm not sure if all tile providers support 12.5. I know some users use other providers and this might break for them if their provider doesn't.
Member
Author
This just sets the map scaling, but the underlying request is still for zoom level 12, so it should work with any z/x/y provider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zoom level right now is pretty much useless, we should start the asset viewer map zoom a bit further out to give more context on the location. You're still able to zoom in more if you want more detail. This will also help with higher cache-hit percentage and faster responses, as zoom level 12 is more likely to be cached