Repository navigation
refactor(server): system config - #1353
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors system-config and immich-config into the domain.
IJobRepositorywhich has anadd(item: JobItem)which is basicallyJobName+ data (typed). This was necessary to remove the bull / queue dependency from the domain.BullModuleto the Infra module (only needed in this one place now, so all the queues are registered there, once)ImmichConfigServiceandSystemConfigServiceintoSystemConfigServiceandSystemConfigCore@app/infra/db/entities- There was a circular dependency caused problems with the tests. Entities have no external dependencies. (Might want to move them to the@app/domainat some point.ISystemConfigRepositoryinterfaceTODO:
JobRepository.addimplementation (or decide if I'll add the implementations as we refactor associated code)This got a little away from me. I didn't realize originally that system config had a dependency on bull queues, but then I didn't want to start over 🤷