Skip to content

feature(server): compute sha1 during upload - #1424

Merged
alextran1502 merged 2 commits into
mainfrom
feature/hash-on-upload
Jan 26, 2023
Merged

alextran1502 merged 2 commits into
mainfrom
feature/hash-on-upload

Conversation

@jrasm91

@jrasm91 jrasm91 commented Jan 26, 2023

Copy link
Copy Markdown
Member

This PR changes the file upload process to compute the sha1 hash during upload. I've wrapped the disk storage engine that we were using before, in order to get access to the stream, otherwise it works the same.

Tested with some images and a 300MB video. When uploading, both processes generate the same sha1.

@vercel

vercel Bot commented Jan 26, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
immich ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 2:44PM (UTC)
immich-code-coverage ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 2:44PM (UTC)

@vercel
vercel Bot temporarily deployed to Preview – immich January 26, 2023 14:43 Inactive
@vercel
vercel Bot temporarily deployed to Preview – immich-code-coverage January 26, 2023 14:44 Inactive
@alextran1502
alextran1502 merged commit c4e1bc3 into main Jan 26, 2023
@alextran1502
alextran1502 deleted the feature/hash-on-upload branch January 26, 2023 19:29

This branch was previously deployed

2 inactive deployments
Preview – immich-code-coverage — 2ba49d41 Deployed Jan 26, 2023 by vercel[bot]
Preview – immich — 2ba49d41 Deployed Jan 26, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants