Repository navigation
build(docker): Use ghcr.io as build cache instead of gha - #1429
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@bo0tzz is attempting to deploy a commit to the immich Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
So cache can only be written when the build is run on the main? |
Member
Author
|
Yes, indeed. With the gha cache, I believe PRs can write cache entries and use them on subsequent runs, but those entries cannot also be used on main. So this isn't a huge difference from that. |
Member
|
I am OK with merging and trying it out. I guess it is quite hard to quantify without actual usage data |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr replaces the gha-internal layer caching with an image pushed to ghcr.io. This works more reliably than the gha cache (which I'm pretty sure is bugged), with the added benefit that there is no 10GB cache limit. One caveat is that pull requests cannot -write- cache entries, because the push fails with a permission error. This is somewhat odd, because normal images can be pushed no problem, but I can't figure it out and it doesn't seem a big issue anyways :P
I'm not 100% confident about this caching approach (it feels a little gross), so I'd like to hear others' opinions on it before this is merged.