Repository navigation
feat(ml): support multiple urls - #14347
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Member
|
We are not using this property in the mobile app so as long as you can login, it is good |
add load balancing section
doc formatting wording wording linting
mertalev
force-pushed
the
feat/ml-multi-remote
branch
from
November 25, 2024 22:59
02083a0 to
b164b9e
Compare
danieldietzler
left a comment
danieldietzler
left a comment
Member
There was a problem hiding this comment.
Code looks good to me, will probably give it a spin tomorrow
jrasm91
reviewed
Nov 26, 2024
jrasm91
left a comment
jrasm91
left a comment
Member
There was a problem hiding this comment.
You have changed it from a string to a list, but all the variable names are still url, which is confusing imo. Should it not be urls now? For compatibility we could support both for a time, give a warning for url, and map that to urls
danieldietzler
approved these changes
Dec 2, 2024
mertalev
enabled auto-merge (squash)
December 4, 2024 19:58
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Dec 20, 2024
* support multiple url * update api * styling unnecessary `?.` * update docs, make new url field go first add load balancing section * update tests doc formatting wording wording linting * small styling * `url` -> `urls` * fix tests * update docs * make docusaurus happy --------- Co-authored-by: Alex <alex.tran1502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A current limitation of remote machine learning is that it expects constant uptime: jobs will fail to be processed if the remote container is down. This PR adds the ability to specify multiple URLs for remote machine learning that are attempted sequentially. This improves the reliability of the feature by allowing a fallback to the local machine learning container when the remote container is not available.
Note: this PR changes the server config type of the machine learning URL to an array. To avoid breaking every Immich instance, string fields are wrapped in an array before validation. I tested with the official mobile app and didn't notice any issues, but I'm not sure if there are any cases where this would be a breaking change.
Testing
Tested that machine learning tasks with one URL work, that specifying two URLs and making the first fail will lead to the second URL being used for that request, and tested the setting UI as in this video
remote-urls.mov