Skip to content

feat(server): specify names for thumbnail files - #14425

Merged
alextran1502 merged 1 commit into
immich-app:mainfrom
eligao:feat/preview-filename
Dec 1, 2024
Merged

alextran1502 merged 1 commit into
immich-app:mainfrom
eligao:feat/preview-filename

Conversation

@eligao

@eligao eligao commented Dec 1, 2024

Copy link
Copy Markdown
Contributor

This change specified a file name for thumbnail files when saved via right click - "Save image as..."
The saved file name will be suffixed with its AssetMediaSize to prevent confusing with the original file.
e.g:

  • IMG_0001.jpg -> IMG_0001_preview.jpg
  • IMG_0002.dng -> IMG_0002_preview.jpg

@danieldietzler danieldietzler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the formatting and test issues

@eligao
eligao force-pushed the feat/preview-filename branch from 08cb47d to 87e0172 Compare December 1, 2024 16:17
Comment thread server/src/services/asset-media.service.ts Outdated
Comment thread server/src/services/asset-media.service.ts Outdated
@eligao
eligao force-pushed the feat/preview-filename branch from 87e0172 to 4618722 Compare December 1, 2024 16:19
@eligao
eligao force-pushed the feat/preview-filename branch from 4618722 to 91216cf Compare December 1, 2024 16:26
@alextran1502
alextran1502 merged commit 4eb7758 into immich-app:main Dec 1, 2024
@eligao
eligao deleted the feat/preview-filename branch December 1, 2024 19:35
yosit pushed a commit to yosit/immich that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants