Repository navigation
fix(server): flaky library e2e tests - #16174
Merged
Merged
Conversation
etnoy
commented
Feb 17, 2025
etnoy
commented
Collaborator
- fix flaky library e2e tests by ensuring we wait for correct queues
- refactor library e2e test queue waiting
etnoy
force-pushed
the
fix/flaky-library-e2e
branch
from
February 17, 2025 22:53
7f0a5d3 to
d716e0d
Compare
etnoy
marked this pull request as ready for review
February 17, 2025 22:57
danieldietzler
approved these changes
Feb 17, 2025
| return key.secret; | ||
| }, | ||
|
|
||
| scan: async (accessToken: string, id: string, wait = false) => { |
Member
There was a problem hiding this comment.
The reason why we had the scan method in the library spec file itself is because no other test needs that functionality. It's probably fine either way though
Collaborator
Author
There was a problem hiding this comment.
I debated back and forth on this and eventually put it in the utils because I see it being used in other e2e tests soon :)
jrasm91
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
