Repository navigation
feat: mobile-web improvements - scrubber - #16856
Merged
Merged
Conversation
|
This is probably going to fix the scrub issue mentioned in #11731. Or is this only targeting timeline? (Don't know if these are still to be implemented separately) |
Collaborator
|
This looks awesome! What would you think about disabling taps on the scrubber, and only allowing dragging? After trying this out, I'm finding it easy to accidentally tap the side of the screen and lose my timeline position, even when the scrubber is hidden. |
Member
|
Do you mind rebasing this? |
midzelis
changed the title
midzelis
changed the title
1 of 3 tasks
Collaborator
|
Also fixes #12387 |
Member
|
I agree with Ben on disabling tap behavior on the scrubber. I also noticed that you put your finger on the left navigation bar, you can scroll the whole asset-grid + sidebar up or down, so it gets in the way of the scrubber to scrub to the bottom of the timeline |
alextran1502
enabled auto-merge (squash)
March 21, 2025 17:58
1 of 3 tasks
2 of 4 tasks
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
* feat: mobile-web improvements - scrubber * lint * cruft * lint * fix: thumb style --------- Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
You can now use touch events to scrub the timeline - for mobile web devices.