Skip to content

fix(web): reset search history after logout - #17534

Merged
alextran1502 merged 1 commit into
mainfrom
fix/search-suggestions
Apr 10, 2025
Merged

alextran1502 merged 1 commit into
mainfrom
fix/search-suggestions

Conversation

@ben-basten

@ben-basten ben-basten commented Apr 10, 2025 •

Copy link
Copy Markdown
Collaborator

Description

Prevents search bar history from being shared between login sessions on the same browser.

How Has This Been Tested?

  1. Login with user A
  2. Perform a couple of searches, and see these searches showing up in the search history dropdown
  3. Logout
  4. Login with user B
  5. Confirm that the search bar history is empty

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

@ben-basten ben-basten changed the title fix(web): reset search suggestions after logout fix(web): reset search history after logout Apr 10, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Deploying preview environment to https://pr-17534.preview.internal.immich.cloud/

@ben-basten
ben-basten force-pushed the fix/search-suggestions branch from 1ec0fc0 to 986595e Compare April 10, 2025 20:29
@ben-basten
ben-basten marked this pull request as ready for review April 10, 2025 20:29

@alextran1502 alextran1502 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@alextran1502
alextran1502 enabled auto-merge (squash) April 10, 2025 20:32
@alextran1502
alextran1502 merged commit 92f0973 into main Apr 10, 2025
@alextran1502
alextran1502 deleted the fix/search-suggestions branch April 10, 2025 20:34
@github-actions github-actions Bot removed the preview label Apr 10, 2025
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
fix(web): reset search suggestions after logout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants