Repository navigation
feat: improve mobile screen reader accessibility - #17876
Merged
Merged
Conversation
bo0tzz
changed the title
atollk
commented
Apr 25, 2025
Contributor
Author
|
It's definitely not complete, but I think it's a nice start to make the photos page work with screen readers. |
atollk
marked this pull request as ready for review
April 25, 2025 22:19
shenlong-tanwen
requested changes
May 7, 2025
# Conflicts: # web/src/lib/components/photos-page/asset-date-group.svelte # web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte
alextran1502
reviewed
May 8, 2025
atollk
force-pushed
the
mobile-accessibility
branch
from
May 8, 2025 16:08
6f51e74 to
00015cc
Compare
shenlong-tanwen
approved these changes
May 27, 2025
# Conflicts: # web/src/lib/components/photos-page/asset-date-group.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds semantic widgets to parts of the mobile app so that screen readers work better.
Two of these are also new to the web frontend.
Fixes #10336
How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)