Repository navigation
fix: delay settings apply for slideshow popup - #18028
Conversation
|
@bo0tzz could you please review? |
bo0tzz
changed the title
|
please have some patience; it's the weekend, and this PR has only been open for 2 days. Someone will get around to reviewing it soon enough. |
|
@bo0tzz apologies, forgot it was the weekend! |
|
Can you help fix the linter error? |
…j0024javia/immich into fix/slideshow-save-btn-fix
|
Updated the code. That should fix the linting errors |
|
|
||
| {#snippet stickyBottom()} | ||
| <Button fullwidth color="primary" onclick={(_) => onClose()}>{$t('done')}</Button> | ||
| <Button fullwidth color="primary" onclick={applyChanges}>{$t('done')}</Button> |
There was a problem hiding this comment.
if we're not going to save these changes immediately, we should have a cancel button, like we do everywhere else. Would you mind adding that?
There was a problem hiding this comment.
I think close button be same as the cancel button. As i am making changes, and i don't want to save, i can just close it?
Let me know if adding cancel would make more sense. will do that
There was a problem hiding this comment.
When you change the date, and on most other actions, it looks something like this:
Please make this change consistent with other modals.
There was a problem hiding this comment.
ok added cancel button and changed text of done -> Confirm as well.
As cancel and done, doesn't seem to make sense, Cancel and Confirm makes more sense
Let me know if you think otherwise
…j0024javia/immich into fix/slideshow-save-btn-fix
… fix/slideshow-save-btn-fix
* fix: fixed slideshow values to apply on done. * chore: linting error fixes * feat: added cancel button and changed text from done to confirm
Description
Fixes #17791
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)