Skip to content

feat: user pin-code - #18138

Merged
jrasm91 merged 5 commits into
mainfrom
user-pincode
May 9, 2025
Merged

feat: user pin-code#18138
jrasm91 merged 5 commits into
mainfrom
user-pincode

Conversation

@alextran1502

@alextran1502 alextran1502 commented May 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds the user's pincode mechanism, which will be used to authorize the viewing of locked photos. The PR adds endpoints for the following mechanisms

  • Check if a user has a PIN code
  • Create a new PIN code
  • Change to a new PIN code
  • Reset PIN code

More detail

  • The user can create a PIN code if no PIN code exists.
  • If the PIN code already exists, the user can change it.
  • The admin can reset the user's PIN code.
image

@alextran1502
alextran1502 marked this pull request as draft May 7, 2025 03:45
@alextran1502
alextran1502 requested a review from jrasm91 May 7, 2025 13:50
@alextran1502
alextran1502 marked this pull request as ready for review May 7, 2025 13:50
alextran1502
alextran1502 commented May 7, 2025
View reviewed changes
Comment thread server/src/schema/tables/user.table.ts Outdated
danieldietzler
danieldietzler reviewed May 7, 2025
View reviewed changes
Comment thread server/src/dtos/auth.dto.ts Outdated
Comment thread server/src/controllers/auth.controller.ts Outdated
Comment thread server/src/services/auth.service.ts Outdated
Comment thread server/src/services/auth.service.ts Outdated
@alextran1502
alextran1502 force-pushed the user-pincode branch 4 times, most recently from 44d58fb to 9dd1264 Compare May 8, 2025 05:59
danieldietzler
danieldietzler reviewed May 8, 2025
View reviewed changes
Comment thread server/src/services/auth.service.ts Outdated
Comment thread server/src/services/auth.service.ts Outdated
Comment thread server/src/services/auth.service.ts Outdated
Comment thread web/src/lib/components/user-settings-page/PincodeInput.svelte Outdated
Comment thread web/src/lib/components/user-settings-page/PincodeInput.svelte Outdated
Comment thread web/src/lib/components/user-settings-page/PincodeInput.svelte Outdated
Comment thread web/src/lib/components/user-settings-page/PincodeInput.svelte Outdated
Comment thread web/src/lib/components/user-settings-page/PincodeSettings.svelte Outdated
Comment thread web/src/lib/components/user-settings-page/PincodeSettings.svelte Outdated
@jrasm91 jrasm91 changed the title feat: user pincode feat: user pin-code May 9, 2025
@jrasm91
jrasm91 merged commit 3f719bd into main May 9, 2025
@jrasm91
jrasm91 deleted the user-pincode branch May 9, 2025 21:01
@DevServs

DevServs commented May 10, 2025

Copy link
Copy Markdown
Contributor

Heading "Change PIN code" is missing for translation. Please add it to Weblate and code substitution.
web/src/lib/components/user-settings-page/PinCodeSettings.svelte
<p class="text-dark">Change PIN code</p>

@danieldietzler danieldietzler mentioned this pull request May 10, 2025
Merged
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
@alextran1502 @jrasm91 @savely-krasovsky
feat: user pin-code (immich-app#18138)
d713cbc 
* feat: user pincode

* pr feedback

* chore: cleanup

---------

Co-authored-by: Jason Rasmussen <jason@rasm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes
@danieldietzler danieldietzler danieldietzler approved these changes

Assignees

No one assigned

Labels

changelog:feature 📱mobile 🗄️server 🖥️web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alextran1502 @DevServs @jrasm91 @danieldietzler