Skip to content

feat(web): clear person birthdate - #18330

Merged
jrasm91 merged 1 commit into
mainfrom
feat/clear-person-birthdate
May 16, 2025
Merged

jrasm91 merged 1 commit into
mainfrom
feat/clear-person-birthdate

Conversation

@jrasm91

@jrasm91 jrasm91 commented May 16, 2025 •

Copy link
Copy Markdown
Member
  • Make it easier to clear and save an empty birthdate
  • Add the option to send an empty string for a birthdate, which maps to null
  • Convert person e2e tests to controller unit tests
  • Fix an issue where the submit button did not trigger setting the birthdate
  • Fix an issue where a uuid was only validated to be a string
  • Fix a reactivity bug where the current page did not reflect changes to the birthdate

image
image

const { status, body } = await request(ctx.getHttpServer())
.get(`/people`)
.query({ closestPersonId: 'invalid' })
.set('Authorization', `Bearer token`);

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer token" is used as [authorization header](1).
const { status, body } = await request(ctx.getHttpServer())
.get(`/people`)
.query({ closestAssetId: 'invalid' })
.set('Authorization', `Bearer token`);

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer token" is used as [authorization header](1).
const { status, body } = await request(ctx.getHttpServer())
.post(`/people`)
.send({ name: null })
.set('Authorization', `Bearer token`);

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer token" is used as [authorization header](1).
const { status, body } = await request(ctx.getHttpServer())
.put(`/people/${factory.uuid()}`)
.send({ featureFaceAssetId: 'invalid' })
.set('Authorization', `Bearer token`);

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer token" is used as [authorization header](1).
const { status, body } = await request(ctx.getHttpServer())
.put(`/people/${factory.uuid()}`)
.send({ isFavorite: 'invalid' })
.set('Authorization', `Bearer token`);

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer token" is used as [authorization header](1).
const { status, body } = await request(ctx.getHttpServer())
.put(`/people/${factory.uuid()}`)
.send({ isHidden: 'invalid' })
.set('Authorization', `Bearer token`);

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer token" is used as [authorization header](1).
@jrasm91
jrasm91 force-pushed the feat/clear-person-birthdate branch from 56bf0d5 to 24d322e Compare May 16, 2025 14:29
@jrasm91
jrasm91 merged commit 28d8357 into main May 16, 2025
@jrasm91
jrasm91 deleted the feat/clear-person-birthdate branch May 16, 2025 15:56
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants