Repository navigation
fix(mobile): reduce stutter/jank on search pages - #18363
Merged
Merged
Conversation
mertalev
approved these changes
May 19, 2025
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
fix: reduce stutter/jank on search pages
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the search pages (like ml search and album search), opening the keyboard shows as a very slow and stuttery animation (Xiaomi 14T pro, Android emulator it looks janky) after performing a search.
The flutter performance profiler shows significant times in rebuild every time the keyboard opens:
It seems like there are some widgets being rebuilt, as also the navigation bar on the bottom briefly changes its size when hiding the keyboard.
I've set
resizeToAvoidBottomInsetto the affected components which should avoid resizing (and therefore probably rebuilding (?) some of the assets. That helps espeically when there are many search results.Flutter performance profiler shows no more significant jank when opening the keyboard (Android emulator).
Can also confirm that the animation is now smooth on my physical phone.
How Has This Been Tested?
Screenshots (if appropriate)
Quick comparison on my phone.
https://streamable.com/4akogh
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)