Skip to content

fix(mobile): Set the currentAsset to the asset clicked when opening an asset from folders - #18825

Merged
alextran1502 merged 1 commit into
immich-app:mainfrom
JobiJoba:fix/share-wrong-asset
Jun 2, 2025
Merged

alextran1502 merged 1 commit into
immich-app:mainfrom
JobiJoba:fix/share-wrong-asset

Conversation

@JobiJoba

@JobiJoba JobiJoba commented Jun 1, 2025 •

Copy link
Copy Markdown
Contributor

Description

Before navigating to the GalleryViewerRoute I'm setting the currentAsset;

The GalleryViewPage use the current asset to show controls and many other features; if not set it won't shows controls; if sets from previous image opening; it will have the wrong asset because it keeps in memory the old asset.

Fixes #17691 - it might fix #18067 also

How Has This Been Tested?

I've done the scenario from issue multiple times with pictures and videos.
(scenario:

  • Open the app
  • Click on any photo of the timeline
  • Press the return button of the smartphone (to get back to the timeline)
  • Go to the library tab, scroll down to the folder button and click it
  • Open any photo from the folder view (I kept pressing the first entry recursively in the folder view, until it became an asset and not a directory)
  • Press the share button
    )

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • [O] I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

I'm not very familiar with Dart test; could you tell me if some need to be written for this issue?

@JobiJoba JobiJoba changed the title fix(mobile) Set the currentAsset to the asset clicked when opening an asset from folders fix(mobile): Set the currentAsset to the asset clicked when opening an asset from folders Jun 1, 2025
@alextran1502
alextran1502 merged commit 3650625 into immich-app:main Jun 2, 2025
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
…n asset from folders (immich-app#18825)

Set the currentAsset to the asset clicked when opening an asset from the folder view ; fix issue immich-app#17691
@exaware

exaware commented Feb 14, 2026

Copy link
Copy Markdown

I still have the issue (#18067) with the newest Android App and newest Immich version.
What is the status of this bug?

@exaware exaware mentioned this pull request Feb 27, 2026
1 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Videos not playing on folder view via mobile (Android) app Folders View Selecting Incorrect Photo for Actions

4 participants