Repository navigation
fix(mobile): Set the currentAsset to the asset clicked when opening an asset from folders - #18825
Merged
Merged
Conversation
…the folder view ; fix issue immich-app#17691
alextran1502
approved these changes
Jun 2, 2025
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…n asset from folders (immich-app#18825) Set the currentAsset to the asset clicked when opening an asset from the folder view ; fix issue immich-app#17691
|
I still have the issue (#18067) with the newest Android App and newest Immich version. |
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before navigating to the GalleryViewerRoute I'm setting the currentAsset;
The GalleryViewPage use the current asset to show controls and many other features; if not set it won't shows controls; if sets from previous image opening; it will have the wrong asset because it keeps in memory the old asset.
Fixes #17691 - it might fix #18067 also
How Has This Been Tested?
I've done the scenario from issue multiple times with pictures and videos.
(scenario:
)
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)I'm not very familiar with Dart test; could you tell me if some need to be written for this issue?