[JobiJoba]

• Added downloadAll method to IDownloadRepository and its implementation in DownloadRepository to handle multiple asset downloads.
• Implemented downloadAllAsset in DownloadStateNotifier to trigger bulk downloads.
• Updated DownloadService to create download tasks for all selected assets.
• Enhanced UI with new download success and failure messages in en.json.
• Added download button to ControlBottomAppBar and integrated download functionality in MultiselectGrid.

Description

Feature request from #5068

Few decision has been taken:

1. Allow to download a file only if he's present remotely (even if he's already present locally also) ; This is a feature that I often use when I lost a picture but could find it in Google Photos, by downloading it; it create a copy but at the top of the stack of my photos.
2. In the gallery asset; we can only download a picture if it's remote and non-local; I would like to change this to be the same as the multi-download
3. Because we can select multiple state of an asset, sometimes it can be remote only, local only, remote and local; I've adapted the message to show a "download (count) files successful - (error) files failed"

I've made a small typo fix which is not really related to this issue here:

      'SelectionAssetState(hasRemote: $hasRemote, hasMerged: $hasMerged, hasMerged: $hasMerged, selectedCount: $selectedCount)';

   'SelectionAssetState(hasRemote: $hasRemote, hasLocal: $hasLocal, hasMerged: $hasMerged, selectedCount: $selectedCount)';

(hasMerged was there two time instead of hasLocal)

--

I think how it works currently is ok but in a better world I would like to also let people download a picture that is only local.
What do you think?

Fixes # (issue)

How Has This Been Tested?

• Select multiple or one asset(s) which are present remotely
• Check that the download button is present
• Click on the download button
• Check if the images are in your local library

--

• Select a non remote asset
• Check that the download button is not present

--

• Select a non remote and a remote asset
• Check that the button download is present
• Check that the remote image is well downloaded.

Screenshots (if appropriate)

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation if applicable
• I have no unrelated changes in the PR.
• I have confirmed that any new dependencies are strictly necessary.
• I have written tests for new code (if applicable)
• I have followed naming conventions/patterns in the surrounding code
• All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
• All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

[alextran1502]

Very clear and concise code! Thanks

[shenlong-tanwen]

Kindly address the comments and update the translation strings to use ICU message format. Thanks for the contribution

[JobiJoba]

All changes from @shenlong-tanwen done; thanks for the review

[JobiJoba]

I'm not sure what makes the i18 fail - someone does have an idea?

[shenlong-tanwen]

I'm not sure what makes the i18 fail - someone does have an idea?

The keys in the translation file must be sorted. You can run the following command from the root directory npm --prefix=web run format:i18n to fix it

[JobiJoba]

Thanks @shenlong-tanwen ;

Do you think we should remove

@override
  Future<bool> download(DownloadTask task) {
    return FileDownloader().enqueue(task);
  }

as it is not used anywhere now?

or should I maybe modify the logic to if only one task call the download method, else call the downloadAll?

I've tried with one asset and multiple asset; all of them download the file correctly

[shenlong-tanwen]

We can remove it and keep things simple. Thanks a lot for working on this

[alextran1502]

Tested and worked well! One potential complaint I can foresee is that "there is no progress bar for the bulk download, so I don't know when it is done"

[JobiJoba]

I was thinking the same, want me to look at how to add the progress bar? (I've tried to add the component but it didn't work but I didn't really look into it)

[akostadinov]

Thank you for the great feature. A couple of suggestions.

I think that downloading a copy by default is suboptimal. Why not make it a non-default user preference or have a separate Download a copy button?

Also showing the file at the top of the stack, does it mean mtime is being messed up?