Skip to content

feat(mobile): add album description functionality - #18886

Merged
alextran1502 merged 5 commits into
immich-app:mainfrom
JobiJoba:editable-description-in-mobile-app
Jun 4, 2025
Merged

alextran1502 merged 5 commits into
immich-app:mainfrom
JobiJoba:editable-description-in-mobile-app

Conversation

@JobiJoba

@JobiJoba JobiJoba commented Jun 3, 2025

Copy link
Copy Markdown
Contributor
  • Introduced a new optional description field in the Album entity.
  • Updated AlbumViewerPageState to manage editDescriptionText.
  • Created AlbumDescription and AlbumViewerEditableDescription widgets for displaying and editing album descriptions.
  • Enhanced CreateAlbumPage to include a description input field.
  • Implemented backend support for updating album descriptions in AlbumApiRepository and AlbumService.
  • Updated sync logic to handle album descriptions during data synchronization.
  • Adjusted UI components to accommodate the new description feature.

Description

We now see in the album view the description of an album, and we can also edit that value.

AlbumSharedUserSelectionPage - I couldn't find where this page is used there is also some logic about album title where we maybe have to add the description

For feature request #9372

How Has This Been Tested?

Scenario 1

  • Open the album tab; check if existing album have a description
  • If have an existing description, edit it; if not check if the message add description is present
  • Click on the description to edit the description

Scenario 2

  • Create a new album
  • Check if the add description is present
  • Add a description and check if it's there via web or in the app

Scenario 3

  • Create a new album and add a description
  • Assign someone else
  • Check if that person can edit the description (should not be able)

Scenario 4

  • Create a new album
  • Don't add a description
  • Should still create the album

Videos

https://github.com/user-attachments/assets/0add8c26-c5f4-49ee-864e-cddaeaa64a80

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@JobiJoba

JobiJoba commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

mmm ok my bad; I see the issue wit the openapi folder I'm going to check how to fix that

JobiJoba added 3 commits June 3, 2025 16:17
- Introduced a new optional `description` field in the `Album` entity.
- Updated `AlbumViewerPageState` to manage `editDescriptionText`.
- Created `AlbumDescription` and `AlbumViewerEditableDescription` widgets for displaying and editing album descriptions.
- Enhanced `CreateAlbumPage` to include a description input field.
- Implemented backend support for updating album descriptions in `AlbumApiRepository` and `AlbumService`.
- Updated sync logic to handle album descriptions during data synchronization.
- Adjusted UI components to accommodate the new description feature.
@JobiJoba
JobiJoba force-pushed the editable-description-in-mobile-app branch from 0dcf6ec to f674061 Compare June 3, 2025 09:17
@JobiJoba

JobiJoba commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

I didn't change the API; sorry for this I change the order of the field desdription in that "generated file DONT EDIT" -_-

@alextran1502
alextran1502 force-pushed the editable-description-in-mobile-app branch 2 times, most recently from 198c688 to ac894b7 Compare June 4, 2025 17:24
@alextran1502
alextran1502 force-pushed the editable-description-in-mobile-app branch from ac894b7 to 5e3e0cd Compare June 4, 2025 17:26
@alextran1502
alextran1502 enabled auto-merge (squash) June 4, 2025 17:26
@alextran1502
alextran1502 disabled auto-merge June 4, 2025 17:32
@alextran1502
alextran1502 enabled auto-merge (squash) June 4, 2025 17:37
@alextran1502
alextran1502 merged commit 5d0ad85 into immich-app:main Jun 4, 2025
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
* feat(mobile): add album description functionality

- Introduced a new optional `description` field in the `Album` entity.
- Updated `AlbumViewerPageState` to manage `editDescriptionText`.
- Created `AlbumDescription` and `AlbumViewerEditableDescription` widgets for displaying and editing album descriptions.
- Enhanced `CreateAlbumPage` to include a description input field.
- Implemented backend support for updating album descriptions in `AlbumApiRepository` and `AlbumService`.
- Updated sync logic to handle album descriptions during data synchronization.
- Adjusted UI components to accommodate the new description feature.

* fix dart analysis error

* remove comment that shouldn't be there

* Album header styling

* fix: disable edit after album creation

---------

Co-authored-by: Alex <alex.tran1502@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants