Repository navigation
feat(mobile): add album description functionality - #18886
Merged
alextran1502 merged 5 commits intoJun 4, 2025
Merged
Conversation
Contributor
Author
|
mmm ok my bad; I see the issue wit the openapi folder I'm going to check how to fix that |
- Introduced a new optional `description` field in the `Album` entity. - Updated `AlbumViewerPageState` to manage `editDescriptionText`. - Created `AlbumDescription` and `AlbumViewerEditableDescription` widgets for displaying and editing album descriptions. - Enhanced `CreateAlbumPage` to include a description input field. - Implemented backend support for updating album descriptions in `AlbumApiRepository` and `AlbumService`. - Updated sync logic to handle album descriptions during data synchronization. - Adjusted UI components to accommodate the new description feature.
JobiJoba
force-pushed
the
editable-description-in-mobile-app
branch
from
June 3, 2025 09:17
0dcf6ec to
f674061
Compare
Contributor
Author
|
I didn't change the API; sorry for this I change the order of the field desdription in that "generated file DONT EDIT" -_- |
alextran1502
force-pushed
the
editable-description-in-mobile-app
branch
2 times, most recently
from
June 4, 2025 17:24
198c688 to
ac894b7
Compare
alextran1502
approved these changes
Jun 4, 2025
alextran1502
force-pushed
the
editable-description-in-mobile-app
branch
from
June 4, 2025 17:26
ac894b7 to
5e3e0cd
Compare
alextran1502
enabled auto-merge (squash)
June 4, 2025 17:26
alextran1502
disabled auto-merge
June 4, 2025 17:32
alextran1502
enabled auto-merge (squash)
June 4, 2025 17:37
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
* feat(mobile): add album description functionality - Introduced a new optional `description` field in the `Album` entity. - Updated `AlbumViewerPageState` to manage `editDescriptionText`. - Created `AlbumDescription` and `AlbumViewerEditableDescription` widgets for displaying and editing album descriptions. - Enhanced `CreateAlbumPage` to include a description input field. - Implemented backend support for updating album descriptions in `AlbumApiRepository` and `AlbumService`. - Updated sync logic to handle album descriptions during data synchronization. - Adjusted UI components to accommodate the new description feature. * fix dart analysis error * remove comment that shouldn't be there * Album header styling * fix: disable edit after album creation --------- Co-authored-by: Alex <alex.tran1502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
descriptionfield in theAlbumentity.AlbumViewerPageStateto manageeditDescriptionText.AlbumDescriptionandAlbumViewerEditableDescriptionwidgets for displaying and editing album descriptions.CreateAlbumPageto include a description input field.AlbumApiRepositoryandAlbumService.Description
We now see in the album view the description of an album, and we can also edit that value.
AlbumSharedUserSelectionPage - I couldn't find where this page is used there is also some logic about album title where we maybe have to add the description
For feature request #9372
How Has This Been Tested?
Scenario 1
Scenario 2
Scenario 3
Scenario 4
https://github.com/user-attachments/assets/0add8c26-c5f4-49ee-864e-cddaeaa64a80Videos
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)