Repository navigation
fix(web): small issues with the memory viewer. - #19184
Merged
Merged
Conversation
If the user refreshed in the browser while on the memory page, the page would show a blank page. This was caused by skipping initialization in afterNavigate. Fix by always initializing the memory page in afterNavigate.
alextran1502
approved these changes
Jun 15, 2025
Member
|
@dagstuan I just tested this PR on main and see why the longer duration in the memory viewer was preferred. With the shorter duration, you will see the artifact of the image loading process when clicking on the arrow icon to navigate forward/backward between images within a memory date. You can reproduce this by opening the developer console > Network > Disable cache. Let me know if you can see this and if you want to open a PR to revert to the default longer default duration. Or perhaps this is a regression of not having the blur thumbnail before loading the preview thumbnail |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
afterNavigatebeing called twice, so this might have been fixed in a newer version of Svelte at some point. In any case, thememoryStoreitself has protections against being initialized multiple times already.How Has This Been Tested?
Tested locally in my browser.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)